Skip to content
Snippets Groups Projects
Commit dea3e762 authored by Mike Antipov's avatar Mike Antipov
Browse files

Fixed major bug EXT-6534 (Snapshot to Disk with Custom Size, selecting...

Fixed major bug EXT-6534 (Snapshot to Disk with Custom Size, selecting Constrain Proportions causes snapshot of the active window with a background to the correct size but the window the same size as original, instead of proportionally changing the active window size.)

* The reason: completely broken functionality to keep all the GUI controls in sync with the saved settings and Preview image state. Issue occurred while upgrading snapshot/social media floater (changeset (1acc14a5e7ac) New snapshot/social media floater)

* Fix: added disabling of floater's buttons depend on snapshot is up to date ("Share Snapshot", "Save Snapshot", "Set As Profile Pic", "Share To Web", "Email Snapshot", "Save To My Inventory", "Save To My Computer").

QA Note: other controls should be checked against necessity to disable them while changing snapshot settings.

Reviewed by Vadim Savchuk at https://codereview.productengine.com/secondlife/r/181/

--HG--
branch : product-engine
parent 3585792e
No related branches found
No related tags found
No related merge requests found
......@@ -1319,7 +1319,27 @@ void LLFloaterSnapshot::Impl::updateLayout(LLFloaterSnapshot* floaterp)
// static
void LLFloaterSnapshot::Impl::updateControls(LLFloaterSnapshot* floater)
{
LLSnapshotLivePreview* previewp = getPreviewView(floater);
if (NULL == previewp)
{
return;
}
// Disable buttons until Snapshot is ready. EXT-6534
BOOL got_snap = previewp->getSnapshotUpToDate();
// process Main buttons
floater->childSetEnabled("share", got_snap);
floater->childSetEnabled("save", got_snap);
floater->childSetEnabled("set_profile_pic", got_snap);
// process Share actions buttons
floater->childSetEnabled("share_to_web", got_snap);
floater->childSetEnabled("share_to_email", got_snap);
// process Save actions buttons
floater->childSetEnabled("save_to_inventory", got_snap);
floater->childSetEnabled("save_to_computer", got_snap);
}
// static
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment