-
- Downloads
DEV-35248: Allow NoVerifySSLCert to uniformly disable verification
Introduce static LLCurl SSL verification flag, default 'true', accessed by LLCurl::setSSLVerify() and getSSLVerify(). Make LLCurl::Easy::prepRequest() check LLCurl::getSSLVerify() instead of unconditionally setting CURLOPT_SSL_VERIFYPEER 'true'. Also set CURLOPT_SSL_VERIFYHOST to match. Make LLXMLRPCTransaction::Impl::init() examine LLCurl::getSSLVerify(), instead of directly examining gSavedSettings.getBOOL("NoVerifySSLCert"). Make LLURLRequest::checkRootCertificate() set CURLOPT_SSL_VERIFYHOST as well as CURLOPT_SSL_VERIFYPEER. Make request() in llhttpclient.cpp (used by LLHTTPClient::getByteRange(), head(), get(), getHeaderOnly(), put(), post(), postRaw(), postFile(), del(), move()) pass LLCurl::getSSLVerify() to checkRootCertificate(), rather than constant 'true'. Make LLAppViewer::mainLoop() call LLCurl::setSSLVerify(! gSavedSettings.getBOOL("NoVerifySSLCert")) at the same time it calls LLCurl::setCAFile(), a comparable bit of static setup.
Showing
- indra/llmessage/llcurl.cpp 18 additions, 2 deletionsindra/llmessage/llcurl.cpp
- indra/llmessage/llcurl.h 11 additions, 0 deletionsindra/llmessage/llcurl.h
- indra/llmessage/llhttpclient.cpp 1 addition, 1 deletionindra/llmessage/llhttpclient.cpp
- indra/llmessage/llurlrequest.cpp 1 addition, 0 deletionsindra/llmessage/llurlrequest.cpp
- indra/newview/llappviewer.cpp 2 additions, 2 deletionsindra/newview/llappviewer.cpp
- indra/newview/llxmlrpctransaction.cpp 2 additions, 3 deletionsindra/newview/llxmlrpctransaction.cpp
Loading
Please register or sign in to comment