Skip to content
Snippets Groups Projects
Commit f4d713ad authored by Andrew Productengine's avatar Andrew Productengine
Browse files

STORM-404 FIXED Fixed crash in LLPanelGroupGeneral::updateMembers().

Crash happened when trying to create new group while other group was still updating. It was caused by invalid iterator mMemberProgress in LLPanelGroupGeneral::updateMembers().
Its usage shouldn't have been reached when member list is cleared and empty thanking to gdatap->isMemberDataComplete() check at the beginning of the function. But when the new group was created while members of other group were still updating this
protection failed: in LLGroupMgr::processGroupMembersReply() for the group being created mMemberDataComplete was set TRUE when group size was zero(because this new group still
had no members). So the check for completness in LLPanelGroupGeneral::updateMembers() was succesfully passed, and further in this method viewer crashed.

- Added check for emptiness of member list into LLPanelGroupGeneral::updateMembers().
parent 42b49397
No related branches found
No related tags found
No related merge requests found
...@@ -692,7 +692,8 @@ void LLPanelGroupGeneral::updateMembers() ...@@ -692,7 +692,8 @@ void LLPanelGroupGeneral::updateMembers()
LLGroupMgrGroupData* gdatap = LLGroupMgr::getInstance()->getGroupData(mGroupID); LLGroupMgrGroupData* gdatap = LLGroupMgr::getInstance()->getGroupData(mGroupID);
if (!mListVisibleMembers || !gdatap if (!mListVisibleMembers || !gdatap
|| !gdatap->isMemberDataComplete()) || !gdatap->isMemberDataComplete()
|| gdatap->mMembers.empty())
{ {
return; return;
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment