Skip to content
Snippets Groups Projects
  1. Sep 16, 2020
  2. Sep 11, 2020
  3. Aug 18, 2020
  4. Aug 10, 2020
  5. Aug 06, 2020
  6. Aug 05, 2020
  7. Aug 03, 2020
  8. Jul 30, 2020
  9. Jul 29, 2020
  10. Jul 28, 2020
  11. Jul 27, 2020
  12. Jul 24, 2020
  13. Jul 23, 2020
  14. Jul 22, 2020
  15. Jul 21, 2020
  16. Jul 20, 2020
  17. Jul 14, 2020
  18. Jul 08, 2020
  19. Jul 07, 2020
    • Nat Goodspeed's avatar
      DRTVWR-476, SL-13555: Don't crash if user closes viewer during login. · 87da08b1
      Nat Goodspeed authored
      Ever since February 2010, the body of the login coroutine function has been
      enclosed in try/catch (...), with an llerrs message to try to crash more
      informatively than the runtime's unhandled-exception termination. Over the
      years this evolved to LL_ERRS and then to CRASH_ON_UNHANDLED_EXCEPTION.
      
      This persisted despite the August 2016 addition of generic catch clauses in
      the LLCoros::toplevel() function to serve the same purpose, and despite the
      subsequent introduction of the LLCoros::Stop family of exceptions to
      deliberately throw into waiting coroutines on viewer shutdown.
      
      That's exactly what was happening. When the user closed the viewer while
      waiting for the response from login.cgi, the waiting operation threw
      LLCoros::Stopping, which was caught by that CRASH_ON_UNHANDLED_EXCEPTION,
      which crashed the viewer with LL_ERRS rather than propagating up to the
      toplevel() and cleanly terminating the coroutine.
      
      Change CRASH_ON_UNHANDLED_EXCEPTION() to LOG_UNHANDLED_EXCEPTION() and
      re-throw so toplevel() can handle.
      87da08b1
  20. Jul 06, 2020
  21. Jul 02, 2020
Loading