Skip to content
Snippets Groups Projects
  1. Sep 05, 2018
  2. Sep 04, 2018
  3. Sep 05, 2018
    • Nat Goodspeed's avatar
    • Nat Goodspeed's avatar
      SL-957: Don't move viewer executable until final viewer_manifest run. · 42931d67
      Nat Goodspeed authored
      viewer_manifest is run twice by CMakeLists.txt: once with --actions=copy and
      once with the default actions copy and package. The fact that we (try to) move
      the Mac viewer executable both times has confused things on a number of
      occasions. Currently it's bollixing our attempt to run dsymutil on the
      executable so we can package up the Mac symbols for both codeticket and
      BugSplat.
      
      Introduce DarwinManifest.is_rearranging() that tests whether either "package"
      or "unpacked" is in self.args["actions"], echoing an earlier test. Make
      several things conditional on that, notably moving the executable.
      42931d67
  4. Sep 04, 2018
  5. Aug 31, 2018
  6. Aug 30, 2018
  7. Aug 27, 2018
    • Nat Goodspeed's avatar
      SL-957: Explicitly pass VIEWER_SYMBOL_FILE from build.sh into CMake · 3f7c75b8
      Nat Goodspeed authored
      instead of relying on both indra/newview/CMakeLists.txt and build.sh
      generating the same file pathname.
      
      Make build.sh set VIEWER_SYMBOL_FILE (instead of symbolfile) in pre_build, and
      pass it to autobuild configure via -D switch. Then the uploads stanza can just
      use VIEWER_SYMBOL_FILE instead of performing its platform-sensitive case
      statement right there.
      
      Introduce VIEWER_SYMBOL_FILE CMake cache variable, default empty string.
      
      Make indra/newview/CMakeLists.txt generate_breakpad_symbols logic conditional
      on VIEWER_SYMBOL_FILE being non-empty, as well as everything else. Eliminate
      local set(VIEWER_SYMBOL_FILE) directives.
      3f7c75b8
  8. Aug 24, 2018
    • Nat Goodspeed's avatar
      DRTVWR-447: Introduce explicit CMake BUGSPLAT_DB variable. · c2178bb6
      Nat Goodspeed authored
      Define the CMake cache variable, with empty string as its default.
      
      Make build.sh pass the BUGSPLAT_DB environment variable as a CMake
      command-line variable assignment.
      
      Change CMake 'if (DEFINED ENV{BUGSPLAT_DB})' to plain 'if (BUGSPLAT_DB)'.
      
      Make CMake pass new --bugsplat switch to every one of SIX different
      invocations of viewer_manifest.py.
      
      Give llmanifest.main() function an argument to allow supplementing the base
      set of command-line switches with additional application-specific switches.
      
      In viewer_manifest.py, define new --bugsplat command-line switch and pass to
      llmanifest.main(). Instead of consulting os.environ['BUGSPLAT_DB'], consult
      self.args['bugsplat'].
      c2178bb6
  9. Aug 23, 2018
    • Nat Goodspeed's avatar
      DRTVWR-447: Add (some) metadata to Mac crash reports. · e674f117
      Nat Goodspeed authored
      This required reordering certain operations during Mac viewer startup. Split
      llappviewermacosx.cpp's initViewer() function into constructViewer() (which
      instantiates LLAppViewerMacOSX) and initViewer() (which calls
      LLAppViewerMacOSX::init()).
      
      llappdelegate-objc.mm's applicationDidFinishLaunching override now calls
      [BugsplatStartupManager start] between constructViewer() and initViewer(): we
      want constructViewer() to have set up the logging subsystem so we can log the
      actions of BugsplatStartupManagerDelegate override methods, but otherwise we
      want BugsplatStartupManager in place as early as possible to catch any early
      crashes. Besides, initViewer() ends up overwriting the static_debug_info.log
      on which we depend for the *previous* run's crash metadata.
      
      Move the code that initializes the pathname of the static_debug_info.log file
      from LLAppViewerMacOSX::init() to the LLAppViewerMacOSX() constructor, since
      BugsplatStartupManagerDelegate override methods need to read (the previous
      run's) file.
      
      Add code to applicationLogForBugsplatStartupManager override to set new
      BugsplatMac 1.0.6 properties userName and userEmail.
      
      Don't log empty fields from static_debug_info.log if we couldn't read it.
      e674f117
  10. Aug 22, 2018
    • Nat Goodspeed's avatar
    • Nat Goodspeed's avatar
    • Nat Goodspeed's avatar
      DRTVWR-447: Attempt to post BugSplat metadata with Mac crash reports. · 7dc01447
      Nat Goodspeed authored
      Introduce CrashMetadata, an LLSingleton in llappviewermacosx.cpp, declared in
      llappviewermacosx-for-objc.h and accessed by the various
      BugsplatStartupManagerDelegate override methods. CrashMetadata is populated by
      reading the previous (presumably crashed) run's static_debug_info.log file.
      
      This replaces the previous getOldLogFilePathname(), getFatalMessage() and
      getAgentFullname() functions. To extend that suite for additional metadata,
      not only would we have to keep adding new free functions, but we'd have to
      keep rereading the static_debug_info.log file.
      
      Override the new applicationKeyForBugsplatStartupManager,
      defaultUserNameForBugsplatStartupManager,
      defaultUserEmailForBugsplatStartupManager methods to extract relevant fields
      from CrashMetadata. Change applicationLogForBugsplatStartupManager and
      attachmentForBugsplatStartupManager to do the same.
      
      Enhance llviewerregion.cpp to update the static_debug_info.log file every
      time we enter a new region.
      7dc01447
  11. Aug 21, 2018
  12. Aug 17, 2018
    • Nat Goodspeed's avatar
      DRTVWR-447: Use os.path.split(path) instead of path.split(os.sep). · 52fe3573
      Nat Goodspeed authored
      On Windows, where 'path' might be separated either with '/' or '\', the latter
      breaks unless all path separators are in fact the os.sep character '\'. While
      it would be possible to code something fancy with os.sep and os.altsep,
      testing the latter for None, much simpler to let os.path.split() handle it.
      52fe3573
  13. Aug 15, 2018
  14. Aug 10, 2018
  15. Aug 02, 2018
  16. Jul 29, 2018
  17. Jul 18, 2018
  18. Jul 17, 2018
  19. Jul 14, 2018
  20. Jul 12, 2018
  21. Jul 11, 2018
Loading