Skip to content
Snippets Groups Projects
  1. Jun 21, 2010
    • Nat Goodspeed's avatar
      EXT-7926: fix broken LD_LIBRARY_PATH handling on Windows. · 4e538adc
      Nat Goodspeed authored
      Recent checkins introduced two different CMake macros SET_TEST_LIST (which
      returned a CMake list of PATH directory strings) and SET_TEST_PATH (which
      returned a single platform-appropriate PATH string). On Windows, whose
      path-separator character is ';', SET_TEST_PATH interacted badly with CMake: in
      CMake, a single string containing ';' characters is indistinguishable from a
      list of strings.
      Eliminate the return-single-string form, redirecting the name SET_TEST_PATH to
      the macro that returns a CMake list. Make LL_TEST_COMMAND expect a list value,
      prepending each directory string with run_build_test.py's -l switch.
      4e538adc
  2. Jun 18, 2010
    • Nat Goodspeed's avatar
      Unmount Mac .sparseimage in case of errors while mounted. · c2b1bf6a
      Nat Goodspeed authored
      DarwinManifest.package_finish() creates and mounts a .sparseimage file,
      populating it with the desired package contents before creating a .dmg from
      it. However, errors while it's mounted would formerly bypass the 'hdiutil
      detach' command that unmounts it, leaving the host in a confused state that
      seemed to prevent subsequent retry attempts from succeeding.
      Also add code to try to diagnose/bypass mysterious SetFile -a V filename
      errors, so far without much luck.
      c2b1bf6a
    • Nat Goodspeed's avatar
      Make run_command() use subprocess.Popen() rather than os.popen(). · d34d8e49
      Nat Goodspeed authored
      This lets us capture the command's stderr as well as stdout. I've been
      perplexed recently by errors from Mac SetFile commands that didn't report
      stderr.
      d34d8e49
    • Nat Goodspeed's avatar
      Centralize LD_LIBRARY_PATH logic with new SET_TEST_PATH macro. · 477fb26c
      Nat Goodspeed authored
      Add ${SHARED_LIB_STAGING_DIR_RELEASE} to LD_LIBRARY_PATH for executing tests:
      otherwise Debug-build tests can't find (e.g.) the aprutil DLL, for which we
      don't build/package a debug variant.
      Leverage discovery that a CMake macro can accept a target variable name
      argument for LL_TEST_COMMAND macro.
      477fb26c
  3. Jun 17, 2010
  4. Jun 16, 2010
Loading