Skip to content
Snippets Groups Projects
  1. Jan 17, 2018
  2. Jan 16, 2018
  3. Jan 12, 2018
  4. Jan 05, 2018
    • callum_linden's avatar
      Fix for MAINT-8119 - this bug morphed from a packaging issue to being all... · d97d7c52
      callum_linden authored
      Fix for MAINT-8119 - this bug morphed from a packaging issue to being all about audio not playing when a media stream started.  There is some as yet, unknown interaction between the volume catcher code in the CEF plugin and the VLC volume controls. The fix for now is to add a Windows call to the VLC code that sets the process volume explicitly.  Later we will address the volume catcher code, move it to a common spot so both CEF and LibVLC can use the same bytes
      d97d7c52
    • callum_linden's avatar
      Fix for MAINT-8148 - AVI fails to play. For Windows, the x-msvideo MIME type... · 6659192a
      callum_linden authored
      Fix for MAINT-8148 - AVI fails to play. For Windows, the x-msvideo MIME type was pointed at CEF which is unable to play it.  Switching that to LibVLC made it work as expected. It was already switched on macOS
      6659192a
  5. Jan 04, 2018
  6. Jan 03, 2018
  7. Jan 02, 2018
  8. Dec 21, 2017
  9. Dec 20, 2017
    • Nat Goodspeed's avatar
      MAINT-8087: Use env vars from VMP for AppData\Roaming and Local. · 5002bf56
      Nat Goodspeed authored
      On Windows, when logged in with a non-ASCII username, every one of the three
      documented APIs -- SHGetSpecialFolderPath(), SHGetFolderPath() and
      SHGetKnownFolderPath() -- fails to retrieve any pathname at all. We cannot
      account for the fact that the oldest of these continues to work with the
      release viewer and within a Python script (though not, curiously, from a
      Python interactive session). With a non-ASCII username, they consistently fail
      when called from an Alex Ivy viewer build: "The filename, directory name, or
      volume label syntax is incorrect."
      
      Empirically, with a non-ASCII username, the preset APPDATA and LOCALAPPDATA
      environment variables are also useless, e.g. c:\Users\??????\AppData\Roaming
      where those are, yup, actual question marks.
      
      Empirically, the VMP is able to successfully call SHGetFolderPath() to
      retrieve both AppData\Roaming and AppData\Local. Therefore, we make the VMP
      set the APPDATA and LOCALAPPDATA environment variables to the UTF-8 encoded
      correct pathnames. Instead of calling SHGetSomethingFolderPath() at all, make
      LLDir_Win32 retrieve those environment variables.
      
      Make LLFile::mkdir() treat "directory already exists" as a success case. Every
      single call fell into one of two categories: either it didn't check success at
      all, or it tested specially to exempt errno == EEXIST. Migrate that test into
      mkdir(); eliminate it from call sites.
      
      Make LLDir::append() and add() convenience functions accept variadic
      arguments. Replace add(add()...) constructs, as well as clumsy concatenations
      of directory names and getDirDelimiter(), with simple variadic add() calls.
      5002bf56
    • Nat Goodspeed's avatar
      36e5f543
    • Nat Goodspeed's avatar
      7c3638e0
    • Oz Linden's avatar
  10. Dec 15, 2017
  11. Dec 14, 2017
  12. Dec 13, 2017
  13. Dec 12, 2017
  14. Dec 07, 2017
  15. Dec 06, 2017
Loading