- Apr 05, 2021
- Mar 09, 2021
-
-
Rye Mutt authored
-
- Jan 18, 2021
-
-
Andrey Kleshchev authored
-
- Dec 17, 2020
-
- Oct 31, 2020
-
-
Rye Mutt authored
-
- Oct 10, 2020
-
- Oct 08, 2020
-
-
Rye Mutt authored
-
- Sep 29, 2020
- Sep 27, 2020
-
-
Kitty Barnett authored
-
- Sep 23, 2020
-
-
Andrey Kleshchev authored
-
- Sep 22, 2020
-
-
Rye Mutt authored
-
- Sep 11, 2020
-
-
Andrey Kleshchev authored
Got into D503 by accident
-
Andrey Kleshchev authored
-
- Sep 09, 2020
-
-
Andrey Kleshchev authored
-
- Aug 24, 2020
-
-
Rye Mutt authored
-
- Aug 09, 2020
- Aug 08, 2020
- Aug 07, 2020
-
-
Rye Mutt authored
-
- Aug 02, 2020
-
-
Rye Mutt authored
-
- Jul 27, 2020
-
-
Rye Mutt authored
-
- Jul 22, 2020
-
- Jul 21, 2020
- May 29, 2020
-
-
Andrey Kleshchev authored
-
- Apr 09, 2020
-
-
Nat Goodspeed authored
-
Nat Goodspeed authored
Apparently, in previous Boost versions, boost::noncopyable was sneaking into the namespace via other headers. Now the compiler complains about its absence without an explicit #include.
-
- Mar 25, 2020
-
-
Nat Goodspeed authored
For reasons not yet diagnosed, specifically in Mac Release builds, the tests in test_httprequest.hpp consistently crash with a backtrace suggesting that the worker thread is calling LLCore::HttpLibcurl::completeRequest() after the foreground thread calls HttpRequest::destroyService(). Weirdly, even executing a tut::skip() call in every test<n>() function up to the point of the crash does not eliminate the crash.
-
Nat Goodspeed authored
NickyD discovered that the substitute default allocator used for llcorehttp tests was returning badly-aligned storage, which caused access violations on alignment-sensitive data such as std::atomic. Thanks Nicky!! Moreover, the llcorehttp test assertions regarding memory usage, well- intentioned though they are, have been causing us trouble for years. Many have already been disabled. The problem is that use of test_allocator.h affected *everything* defined with that header file's declarations visible. That inevitably included specific functions in other subsystems. Those functions then (unintentionally) consumed the special allocator, throwing off the memory tracking and making certain memory-related assertions consistently fail. This is a particular, observable bad effect of One Definition Rule violations. Within a given program, C++ allows multiple definitions for the same entity, but requires that all such definitions be the same. Partial visibility of the global operator new() and operator delete() overrides meant that some definitions of certain entities used the default global allocator, some used llcorehttp's. There may have been other, more subtle bad effects of these ODR violations. If one wanted to reimplement verification of the memory consumption of llcorehttp classes: * Each llcorehttp class (for which memory tracking was desired) should declare class-specific operator new() and operator delete() methods. Naturally, these would all consume a central llcorehttp-specific allocator, but that allocator should *not* be named global operator new(). * Presumably that would require runtime indirection to allow using the default allocator in production while substituting the special allocator for tests. * Recording and verifying the memory consumption in each test should be performed in the test-object constructor and destructor, rather than being sprinkled throughout the test<n>() methods. * With that mechanism in place, the test object should provide methods to adjust (or entirely disable) memory verification for a particular test. * The test object should also provide a "yes, we're still consuming llcorehttp memory" method to be used for spot checks in the middle of tests -- instead of sprinkling in explicit comparisons as before. * In fact, the llcorehttp test object in each test_*.hpp file should be derived from a central llcorehttp test-object base class providing those methods.
-
Nat Goodspeed authored
Hopefully this is temporary until we solve the problem of crashy llcorehttp test executable on Mac.
-
Anchor authored
-
Anchor authored
-