Skip to content
Snippets Groups Projects
  1. Oct 14, 2011
  2. Apr 12, 2011
  3. Feb 16, 2011
  4. Feb 09, 2011
  5. Feb 05, 2011
    • Aleric Inglewood's avatar
      Introduces a LLThreadLocalData class that can be · ef490e30
      Aleric Inglewood authored
      accessed through the static LLThread::tldata().
      Currently this object contains two (public) thread-local
      objects: a LLAPRRootPool and a LLVolatileAPRPool.
      
      The first is the general memory pool used by this thread
      (and this thread alone), while the second is intended
      for short lived memory allocations (needed for APR).
      The advantages of not mixing those two is that the latter
      is used most frequently, and as a result of it's nature
      can be destroyed and reconstructed on a "regular" basis.
      
      This patch adds LLAPRPool (completely replacing the old one),
      which is a wrapper around apr_pool_t* and has complete
      thread-safity checking.
      
      Whenever an apr call requires memory for some resource,
      a memory pool in the form of an LLAPRPool object can
      be created with the same life-time as this resource;
      assuring clean up of the memory no sooner, but also
      not much later than the life-time of the resource
      that needs the memory.
      
      Many, many function calls and constructors had the
      pool parameter simply removed (it is no longer the
      concern of the developer, if you don't write code
      that actually does an libapr call then you are no
      longer bothered with memory pools at all).
      
      However, I kept the notion of short-lived and
      long-lived allocations alive (see my remark in
      the jira here: https://jira.secondlife.com/browse/STORM-864?focusedCommentId=235356&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-235356
      which requires that the LLAPRFile API needs
      to allow the user to specify how long they
      think a file will stay open. By choosing
      'short_lived' as default for the constructor
      that immediately opens a file, the number of
      instances where this needs to be specified is
      drastically reduced however (obviously, any
      automatic LLAPRFile is short lived).
      
      ***
      
      Addressed Boroondas remarks in https://codereview.secondlife.com/r/99/
      regarding (doxygen) comments. This patch effectively only changes comments.
      
      Includes some 'merge' stuff that ended up in llvocache.cpp
      (while starting as a bug fix, now only resulting in a cleanup).
      
      ***
      
      Added comment 'The use of apr_pool_t is OK here'.
      
      Added this comment on every line where apr_pool_t
      is correctly being used.
      
      This should make it easier to spot (future) errors
      where someone started to use apr_pool_t; you can
      just grep all sources for 'apr_pool_t' and immediately
      see where it's being used while LLAPRPool should
      have been used.
      
      Note that merging this patch is very easy:
      If there are no other uses of apr_pool_t in the code
      (one grep) and it compiles, then it will work.
      
      ***
      
      Second Merge (needed to remove 'delete mCreationMutex'
      from LLImageDecodeThread::~LLImageDecodeThread).
      
      ***
      
      Added back #include <apr_pools.h>.
      
      Apparently that is needed on libapr version 1.2.8.,
      the version used by Linden Lab, for calls to
      apr_queue_*. This is a bug in libapr (we also
      include <apr_queue.h>, that is fixed in (at least) 1.3.7.
      
      Note that 1.2.8 is VERY old. Even 1.3.x is old.
      
      ***
      
      License fixes (GPL -> LGPL). And typo in comments.
      Addresses merov's comments on the review board.
      
      ***
      
      Added Merov's compile fixes for windows.
      ef490e30
  6. Jan 14, 2011
  7. Jan 13, 2011
  8. Dec 01, 2010
  9. Nov 16, 2010
  10. Oct 13, 2010
  11. Sep 23, 2010
  12. Sep 21, 2010
  13. Sep 15, 2010
  14. Sep 10, 2010
  15. Aug 17, 2010
  16. Aug 13, 2010
  17. Aug 10, 2010
  18. Apr 27, 2010
    • Monroe Linden's avatar
      Architectural changes to LLPlugin message processing. · dacc5afb
      Monroe Linden authored
      LLPluginProcessParent can now optionally use a separate thread for reading messages from plugin sockets.  If this is enabled, it will spawn a single thread and use apr_pollset_poll to wake up the thread when incoming data arrives instead of polling all the descriptors round-robin every frame.  This should be somewhat more efficient, and should also allow blocking requests from plugins to be serviced much more quickly (once we start using them).  This is currently disabled by default, until it's had a bit more focused testing on multiple platforms.
      
      Hooked up the switch to use the message read thread to the PluginUseReadThread debug setting and an item in the Advanced menu in the viewer, and to a checkbox in the UI in llmediaplugintest.
      
      Updated some debug logging in the plugin system to have appropriate tags and not log dire-looking warnings during normal operation.
      
      LLPluginProcessParent now once again explicitly kills plugin processes (instead of just closing their sockets and waiting for them to exit).  The problem we were attempting to solve by not doing the kill (letting the webkit plugin write its cookie file on exit) has been solved another way.
      
      LLPluginProcessParent::sendMessage() now attempts to write the outgoing message to the socket immediately instead of waiting for the next frame.  This should reduce the latency of sending plugin messages.
      
      Added a separate fast timer for LLViewerMedia::updateMedia().
      dacc5afb
  19. Mar 29, 2010
  20. Mar 16, 2010
    • Monroe Linden's avatar
      Added an "init" message in LLPLUGIN_MESSAGE_CLASS_MEDIA, and made... · ce242821
      Monroe Linden authored
      Added an "init" message in LLPLUGIN_MESSAGE_CLASS_MEDIA, and made LLPluginClassMedia queue it up before initializing its LLPluginProcessParent.
      Made all existing plugins send their texture_params message from this init message instead of the LLPLUGIN_MESSAGE_CLASS_BASE "init" message.  (This ensures that they won't start to receive 'size_change' messages until after the init has happened.)
      Added "set_user_data_path" and "set_language_code" messages to LLPluginClassMedia.
      Made webkit plugin deal with the new messages, when they're sent before it receives the media "init".
      Removed the user_data_path and language_code arguments from the init function calls throughout the hierarchy.
      Made LLViewerMediaImpl queue up the language code and user data path messages before initializing the media.
      
      Reviewed by Callum at http://codereview.lindenlab.com/687006 .
      ce242821
    • Monroe Linden's avatar
      The movie URLs we were using on movies.apple.com now need to be accessed as... · ec0a2b98
      Monroe Linden authored
      The movie URLs we were using on movies.apple.com now need to be accessed as trailers.apple.com instead.
      ec0a2b98
  21. Mar 05, 2010
  22. Mar 04, 2010
  23. Jan 18, 2010
    • Monroe Linden's avatar
      Added getNativeKeyData() function to LLWindow and LLWindowMacOSX. · fae9c8fe
      Monroe Linden authored
      Added an LLSD argument to LLPluginClassMedia::keyEvent() and LLPluginClassMedia::textInput() which contains the native key data.
      Made LLViewerMediaImpl retrieve the native key data and pass it to keyEvent and textInput.
      Added a native_key_data parameter to the text_event and key_event messages.
      Made the webkit plugin extract the native_key_data parameter and pass it to the internal keyEvent() and unicodeInput() functions.
      Fixed LLMediaPluginTest to match function signature change to LLPluginClassMedia::keyEvent().
      fae9c8fe
  24. Dec 18, 2009
  25. Dec 15, 2009
  26. Dec 11, 2009
  27. Dec 10, 2009
  28. Dec 09, 2009
  29. Nov 16, 2009
  30. Nov 05, 2009
  31. Oct 30, 2009
  32. Oct 26, 2009
Loading