- Apr 18, 2021
-
-
Rye Mutt authored
-
- Jul 27, 2020
-
-
Rye Mutt authored
-
- Jul 19, 2020
-
-
Rye Mutt authored
-
- Mar 26, 2020
-
-
Nat Goodspeed authored
-
- Mar 25, 2020
-
-
Nat Goodspeed authored
LLWearableType::initSingleton() calls LLWearableDictionary::initParamSingleton(). LLWearableDictionary's constructor constructs specific WearableEntry instances, each of which wants to translate its name string to a user-facing label using LLWearableType::mTrans. WearableEntry's constructor was calling LLWearableType::getInstance(). Under circumstances we don't fully understand (recursive mutex misbehavior?), that could hang. Instead, pass the canonical LLWearableType instance to LLWearableDictionary's constructor, and from there into WearableEntry's constructor.
-
- Nov 13, 2019
-
-
andreykproductengine authored
-
- Aug 12, 2019
-
-
andreykproductengine authored
-
- Aug 01, 2018
-
-
maxim_productengine authored
-
- Jun 08, 2018
-
-
Anchor Linden authored
-
- Mar 06, 2018
-
-
Rider Linden authored
-
- Sep 15, 2016
-
-
Nat Goodspeed authored
A shocking number of LLSingleton subclasses had public constructors -- and in several instances, were being explicitly instantiated independently of the LLSingleton machinery. This breaks the new LLSingleton dependency-tracking machinery. It seems only fair that if you say you want an LLSingleton, there should only be ONE INSTANCE! Introduce LLSINGLETON() and LLSINGLETON_EMPTY_CTOR() macros. These handle the friend class LLSingleton<whatevah>; and explicitly declare a private nullary constructor. To try to enforce the LLSINGLETON() convention, introduce a new pure virtual LLSingleton method you_must_use_LLSINGLETON_macro() which is, as you might suspect, defined by the macro. If you declare an LLSingleton subclass without using LLSINGLETON() or LLSINGLETON_EMPTY_CTOR() in the class body, you can't instantiate the subclass for lack of a you_must_use_LLSINGLETON_macro() implementation -- which will hopefully remind the coder. Trawl through ALL LLSingleton subclass definitions, sprinkling in LLSINGLETON() or LLSINGLETON_EMPTY_CTOR() as appropriate. Remove all explicit constructor declarations, public or private, along with relevant 'friend class LLSingleton<myself>' declarations. Where destructors are declared, move them into private section as well. Where the constructor was inline but nontrivial, move out of class body. Fix several LLSingleton abuses revealed by making ctors/dtors private: LLGlobalEconomy was both an LLSingleton and the base class for LLRegionEconomy, a non-LLSingleton. (Therefore every LLRegionEconomy instance contained another instance of the LLGlobalEconomy "singleton.") Extract LLBaseEconomy; LLGlobalEconomy is now a trivial subclass of that. LLRegionEconomy, as you might suspect, now derives from LLBaseEconomy. LLToolGrab, an LLSingleton, was also explicitly instantiated by LLToolCompGun's constructor. Extract LLToolGrabBase, explicitly instantiated, with trivial subclass LLToolGrab, the LLSingleton instance. (WARNING: LLToolGrabBase methods have an unnerving tendency to go after LLToolGrab::getInstance(). I DO NOT KNOW what should be the relationship between the instance in LLToolCompGun and the LLToolGrab singleton instance.) LLGridManager declared a variant constructor accepting (const std::string&), with the comment: // initialize with an explicity grid file for testing. As there is no evidence of this being called from anywhere, delete it. LLChicletBar's constructor accepted an optional (const LLSD&). As the LLSD parameter wasn't used, and as there is no evidence of it being passed from anywhere, delete the parameter. LLViewerWindow::shutdownViews() was checking LLNavigationBar:: instanceExists(), then deleting its getInstance() pointer -- leaving a dangling LLSingleton instance pointer, a land mine if any subsequent code should attempt to reference it. Use deleteSingleton() instead. ~LLAppViewer() was calling LLViewerEventRecorder::instance() and then explicitly calling ~LLViewerEventRecorder() on that instance -- leaving the LLSingleton instance pointer pointing to an allocated-but-destroyed instance. Use deleteSingleton() instead.
-
- Nov 10, 2015
-
-
Oz Linden authored
-
- Mar 09, 2015
-
-
Brad Payne (Vir Linden) authored
-
- Mar 05, 2015
-
-
Brad Payne (Vir Linden) authored
SL-103 WIP - viewer enforces wearable limits based on total articles of clothing rather than per-type limit. Limit is artificially low for testing, will bump before release.
-
- Aug 05, 2014
-
-
Kitty Barnett authored
--HG-- branch : Appearance-Misc
-
- Apr 30, 2013
-
-
Graham Madarasz authored
-
- Mar 29, 2013
-
-
Graham Madarasz authored
-
- Sep 03, 2012
-
-
Don Kjer authored
-
- May 29, 2011
-
-
Kitty Barnett authored
--HG-- branch : Appearance-Misc
-
- Apr 20, 2011
-
-
Loren Shih authored
Changed this to be expected behavior, where top wearable's characteristics are used.
-
Loren Shih authored
Changed this to be expected behavior, where top wearable's characteristics are used.
-
- Apr 11, 2011
-
-
Loren Shih authored
Crash was because we weren't checking for null wearable lookups.
-
- Apr 08, 2011
-
-
Dave SIMmONs authored
Fixed a NULL pointer crash found while using viewer. See https://osiris.lindenlab.com/viewer_crash_browser/index.php?filter_id=24941. Reviewed by Kelly
-
- Oct 13, 2010
-
-
Oz Linden authored
-
- Sep 21, 2010
-
-
Brad Payne (Vir Linden) authored
-
- Aug 30, 2010
-
-
Loren Shih authored
-
Loren Shih authored
Added backwards compatibility support for new wearable types.
-
- Aug 23, 2010
-
-
Loren Shih authored
Added debug setting for disabling physics. Added disable-multiwear and disable-camera-reset to wearabletype.
-
- Aug 22, 2010
-
-
Kitty Barnett authored
--HG-- branch : RLVa
-
- Aug 13, 2010
-
-
Oz Linden authored
-
- Jun 22, 2010
-
-
Richard Linden authored
reviewed by Leyla
-
- May 28, 2010
-
-
Nyx (Neal Orman) authored
Implemented some resident-suggested tweaks to better support multiwearables code reviewed by Seraph
-
- May 13, 2010
-
-
Loren Shih authored
Change enum naming to use WT_INVALID=255 instead of WT_NONE=255. Added WT_NONE as -1.
-
- May 11, 2010
-
-
Loren Shih authored
Name change LLWearableDictionary.h to LLWearableType.h.
-