Skip to content
Snippets Groups Projects
  1. Apr 18, 2021
  2. Jul 27, 2020
  3. Jul 19, 2020
  4. Mar 26, 2020
  5. Mar 25, 2020
    • Nat Goodspeed's avatar
      DRTVWR-476: Eliminate LLWearableType LLSingleton circularity. · 26c59509
      Nat Goodspeed authored
      LLWearableType::initSingleton() calls LLWearableDictionary::initParamSingleton().
      LLWearableDictionary's constructor constructs specific WearableEntry
      instances, each of which wants to translate its name string to a user-facing
      label using LLWearableType::mTrans.
      
      WearableEntry's constructor was calling LLWearableType::getInstance(). Under
      circumstances we don't fully understand (recursive mutex misbehavior?), that
      could hang.
      
      Instead, pass the canonical LLWearableType instance to LLWearableDictionary's
      constructor, and from there into WearableEntry's constructor.
      26c59509
  6. Nov 13, 2019
  7. Aug 12, 2019
  8. Aug 01, 2018
  9. Jun 08, 2018
  10. Mar 06, 2018
  11. Sep 15, 2016
    • Nat Goodspeed's avatar
      MAINT-5232: Normalize LLSingleton subclasses. · d2c3c2f9
      Nat Goodspeed authored
      A shocking number of LLSingleton subclasses had public constructors -- and in
      several instances, were being explicitly instantiated independently of the
      LLSingleton machinery. This breaks the new LLSingleton dependency-tracking
      machinery. It seems only fair that if you say you want an LLSingleton, there
      should only be ONE INSTANCE!
      
      Introduce LLSINGLETON() and LLSINGLETON_EMPTY_CTOR() macros. These handle the
      friend class LLSingleton<whatevah>;
      and explicitly declare a private nullary constructor.
      
      To try to enforce the LLSINGLETON() convention, introduce a new pure virtual
      LLSingleton method you_must_use_LLSINGLETON_macro() which is, as you might
      suspect, defined by the macro. If you declare an LLSingleton subclass without
      using LLSINGLETON() or LLSINGLETON_EMPTY_CTOR() in the class body, you can't
      instantiate the subclass for lack of a you_must_use_LLSINGLETON_macro()
      implementation -- which will hopefully remind the coder.
      
      Trawl through ALL LLSingleton subclass definitions, sprinkling in
      LLSINGLETON() or LLSINGLETON_EMPTY_CTOR() as appropriate. Remove all explicit
      constructor declarations, public or private, along with relevant 'friend class
      LLSingleton<myself>' declarations. Where destructors are declared, move them
      into private section as well. Where the constructor was inline but nontrivial,
      move out of class body.
      
      Fix several LLSingleton abuses revealed by making ctors/dtors private:
      
      LLGlobalEconomy was both an LLSingleton and the base class for
      LLRegionEconomy, a non-LLSingleton. (Therefore every LLRegionEconomy instance
      contained another instance of the LLGlobalEconomy "singleton.") Extract
      LLBaseEconomy; LLGlobalEconomy is now a trivial subclass of that.
      LLRegionEconomy, as you might suspect, now derives from LLBaseEconomy.
      
      LLToolGrab, an LLSingleton, was also explicitly instantiated by
      LLToolCompGun's constructor. Extract LLToolGrabBase, explicitly instantiated,
      with trivial subclass LLToolGrab, the LLSingleton instance.
      
      (WARNING: LLToolGrabBase methods have an unnerving tendency to go after
      LLToolGrab::getInstance(). I DO NOT KNOW what should be the relationship
      between the instance in LLToolCompGun and the LLToolGrab singleton instance.)
      
      LLGridManager declared a variant constructor accepting (const std::string&),
      with the comment:
      // initialize with an explicity grid file for testing.
      As there is no evidence of this being called from anywhere, delete it.
      
      LLChicletBar's constructor accepted an optional (const LLSD&). As the LLSD
      parameter wasn't used, and as there is no evidence of it being passed from
      anywhere, delete the parameter.
      
      LLViewerWindow::shutdownViews() was checking LLNavigationBar::
      instanceExists(), then deleting its getInstance() pointer -- leaving a
      dangling LLSingleton instance pointer, a land mine if any subsequent code
      should attempt to reference it. Use deleteSingleton() instead.
      
      ~LLAppViewer() was calling LLViewerEventRecorder::instance() and then
      explicitly calling ~LLViewerEventRecorder() on that instance -- leaving the
      LLSingleton instance pointer pointing to an allocated-but-destroyed instance.
      Use deleteSingleton() instead.
      d2c3c2f9
  12. Nov 10, 2015
  13. Mar 09, 2015
  14. Mar 05, 2015
  15. Aug 05, 2014
  16. Apr 30, 2013
  17. Mar 29, 2013
  18. Sep 03, 2012
  19. May 29, 2011
  20. Apr 20, 2011
  21. Apr 11, 2011
  22. Apr 08, 2011
  23. Oct 13, 2010
  24. Sep 21, 2010
  25. Aug 30, 2010
  26. Aug 23, 2010
    • Loren Shih's avatar
      Created new wearable type. · 981a43b3
      Loren Shih authored
      Added debug setting for disabling physics.
      Added disable-multiwear and disable-camera-reset to wearabletype.
      981a43b3
  27. Aug 22, 2010
  28. Aug 13, 2010
  29. Jun 22, 2010
  30. May 28, 2010
  31. May 13, 2010
  32. May 11, 2010
Loading