Skip to content
Snippets Groups Projects
  1. Nov 10, 2011
  2. Nov 02, 2011
  3. Oct 31, 2011
  4. Oct 25, 2011
  5. Oct 14, 2011
  6. Sep 12, 2011
  7. Aug 29, 2011
  8. Aug 26, 2011
  9. Aug 17, 2011
  10. Jul 29, 2011
  11. Jun 09, 2011
  12. May 25, 2011
  13. May 18, 2011
  14. May 13, 2011
  15. Apr 17, 2011
  16. Mar 25, 2011
  17. Mar 23, 2011
  18. Mar 17, 2011
  19. Mar 15, 2011
  20. Mar 04, 2011
  21. Feb 05, 2011
    • Aleric Inglewood's avatar
      Introduces a LLThreadLocalData class that can be · ef490e30
      Aleric Inglewood authored
      accessed through the static LLThread::tldata().
      Currently this object contains two (public) thread-local
      objects: a LLAPRRootPool and a LLVolatileAPRPool.
      
      The first is the general memory pool used by this thread
      (and this thread alone), while the second is intended
      for short lived memory allocations (needed for APR).
      The advantages of not mixing those two is that the latter
      is used most frequently, and as a result of it's nature
      can be destroyed and reconstructed on a "regular" basis.
      
      This patch adds LLAPRPool (completely replacing the old one),
      which is a wrapper around apr_pool_t* and has complete
      thread-safity checking.
      
      Whenever an apr call requires memory for some resource,
      a memory pool in the form of an LLAPRPool object can
      be created with the same life-time as this resource;
      assuring clean up of the memory no sooner, but also
      not much later than the life-time of the resource
      that needs the memory.
      
      Many, many function calls and constructors had the
      pool parameter simply removed (it is no longer the
      concern of the developer, if you don't write code
      that actually does an libapr call then you are no
      longer bothered with memory pools at all).
      
      However, I kept the notion of short-lived and
      long-lived allocations alive (see my remark in
      the jira here: https://jira.secondlife.com/browse/STORM-864?focusedCommentId=235356&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-235356
      which requires that the LLAPRFile API needs
      to allow the user to specify how long they
      think a file will stay open. By choosing
      'short_lived' as default for the constructor
      that immediately opens a file, the number of
      instances where this needs to be specified is
      drastically reduced however (obviously, any
      automatic LLAPRFile is short lived).
      
      ***
      
      Addressed Boroondas remarks in https://codereview.secondlife.com/r/99/
      regarding (doxygen) comments. This patch effectively only changes comments.
      
      Includes some 'merge' stuff that ended up in llvocache.cpp
      (while starting as a bug fix, now only resulting in a cleanup).
      
      ***
      
      Added comment 'The use of apr_pool_t is OK here'.
      
      Added this comment on every line where apr_pool_t
      is correctly being used.
      
      This should make it easier to spot (future) errors
      where someone started to use apr_pool_t; you can
      just grep all sources for 'apr_pool_t' and immediately
      see where it's being used while LLAPRPool should
      have been used.
      
      Note that merging this patch is very easy:
      If there are no other uses of apr_pool_t in the code
      (one grep) and it compiles, then it will work.
      
      ***
      
      Second Merge (needed to remove 'delete mCreationMutex'
      from LLImageDecodeThread::~LLImageDecodeThread).
      
      ***
      
      Added back #include <apr_pools.h>.
      
      Apparently that is needed on libapr version 1.2.8.,
      the version used by Linden Lab, for calls to
      apr_queue_*. This is a bug in libapr (we also
      include <apr_queue.h>, that is fixed in (at least) 1.3.7.
      
      Note that 1.2.8 is VERY old. Even 1.3.x is old.
      
      ***
      
      License fixes (GPL -> LGPL). And typo in comments.
      Addresses merov's comments on the review board.
      
      ***
      
      Added Merov's compile fixes for windows.
      ef490e30
  22. Jan 13, 2011
  23. Dec 21, 2010
  24. Dec 15, 2010
  25. Dec 03, 2010
  26. Dec 01, 2010
  27. Nov 30, 2010
  28. Nov 16, 2010
  29. Nov 09, 2010
  30. Nov 05, 2010
  31. Oct 13, 2010
  32. Sep 23, 2010
    • Tofu Linden's avatar
      Backed out changeset acb451f83a9d · 0f391c6a
      Tofu Linden authored
      original commit log for acb451f83a9d was: "Temporary changes to allow the viewer to build against an older version of llqtwebkit.
      NOTE: once updated builds of llqtwebkit are available on all platforms, this changeset should be backed out."
      
      So, yes, I'm backing that out.
      0f391c6a
  33. Sep 22, 2010
Loading