Skip to content
Snippets Groups Projects
  1. Jun 30, 2016
    • Nat Goodspeed's avatar
      DRTVWR-418: Unify control flow through LLAppViewer across platforms. · 464a0df4
      Nat Goodspeed authored
      The LLApp API used to consist of init(), mainLoop(), cleanup() methods. This
      makes sense -- but on Mac that structure was being subverted. The method
      called mainLoop() was in fact being called once per frame. There was
      initialization code in the method, which (on Mac) needed to be skipped with an
      already-initialized bool. There was a 'while' loop which (on Mac) needed to be
      turned into an 'if' instead so the method would return after every frame.
      
      Rename LLApp::mainLoop() to frame(). Propagate through subclasses LLAppViewer
      and LLCrashLogger. Document the fact that frame() returns true to mean "done."
      (This was always the case, but had to be inferred from the code.)
      
      Rename the Mac Objective-C function mainLoop to oneFrame. Rename the C++ free
      function it calls from runMainLoop() to pumpMainLoop(). Add comments to
      llappdelegate-objc.mm explaining (inferred) control flow.
      
      Change the Linux viewer main() and the Windows viewer WINMAIN() from a single
      LLAppViewer::mainLoop() call to repeatedly call frame() until it returns true.
      
      Move initialization code from the top of LLAppViewer::frame() to the init()
      method, where it more properly belongs. Remove corresponding
      mMainLoopInitialized flag (and all references) from LLAppViewer.
      
      Remove 'while (! LLApp::isExiting())' (or on Mac, 'if (! LLApp::isExiting())')
      from LLAppViewer::frame() -- thus unindenting the whole body of the 'while'
      and causing many lines of apparent change. (Apologies to reviewers.)
      
      There are four LLApp states: APP_STATUS_RUNNING, APP_STATUS_QUITTING,
      APP_STATUS_STOPPED and APP_STATUS_ERROR. Change LLAppViewer::frame() return
      value from (isExiting()) (QUITTING or ERROR) to (! isRunning()). I do not know
      under what circumstances the state might transition to STOPPED during a
      frame() call, but I'm quite sure that if it does, we don't want to call
      frame() again. We only want a subsequent call if the state is RUNNING.
      
      Also rename mainLoop() method in LLCrashLogger subclasses
      LLCrashLoggerWindows, LLCrashLoggerMac, LLCrashLoggerLinux. Of course it's
      completely up to the frame() method whether to yield control; none of those in
      fact do. Honor protocol by returning true (frame() is done), even though each
      one's main() caller ignores the return value.
      
      In fact LLCrashLoggerWindows::mainLoop() wasn't using the return protocol
      correctly anyway, returning wParam or 0 or 1 -- possibly because the return
      protocol was never explicitly documented. It should always return true: "I'm
      done, don't call me again."
      464a0df4
  2. Nov 10, 2015
  3. Dec 03, 2013
  4. Aug 15, 2013
  5. Mar 29, 2013
  6. Oct 27, 2011
  7. Jul 12, 2011
  8. Oct 13, 2010
  9. Sep 21, 2010
  10. Aug 13, 2010
  11. May 27, 2010
  12. Mar 09, 2009
  13. Feb 03, 2009
  14. Jan 07, 2009
  15. Jun 25, 2008
  16. Feb 19, 2008
    • Steven Bennetts's avatar
      merge -r 78989:80279 Branch_1-19-0-Viewer-> release · 903292ba
      Steven Bennetts authored
      Changes from 1.19.0.2 and 1.19.0.3
      
      DEV-9226 Some Dazzle? icons have sneaked into the release branch
      DEV-9226 - lock icon not appearing in properties window for no-modify inventory items
      DEV-8771 Preferences > Web has truncated text in the Address: section, ported and tested minor xml change
      DEV-9736 commit 1.19.0 second set of translated xui strings
      DEV-9825 Make the region info message a passive notification
      DEV-7714 - Korean viewer crashes on startup.
      DEV-9759 - Stand up button etc dissapear offscreen after using mouselook
      DEV-9938 client-readme-voice.txt missing from open source distribution
      DEV-9436 Changed default SL window size to 1000x700, to allow buttons in UI to have proper labels (Communicate) and search to fit onscreen.
      DEV-10031    	Clicking on another users classifieds ad then closing asks you to save changes
      DEV-10066    	Checking to select a role does not enable the apply button
      DEV-8809    	stray 'Done" on the Profile Web tab
      DEV-8515 Debug settings overrides do not work for booleans.  svn merge -r77376:77377 sl-parcelmedia-3.  OK by cg.
      DEV-10083: Preferences window docks at an offscreen position and cannot be moved vertically
      DEV-10186 - LLIMPanel kills the framerate for group ims.
      DEV-10108 Viewer freeze and delay in opening map
      DEV-10115 Visible flashing of prim highlight when editing
      DEV-10112 	Parcel audio play setting is not remembered when crossing over a parcel with no media
      DEV-10109 	Alt and left/right arrow keys dont move you between tabs
      DEV-10093 	Login Page > SL Release link overlaps Quit when viewer resized
      DEV-10048 	Redocking the Contact list causes the communicate ui to get ugly
      DEV-8131  	 Deutsch "System Default" is translated as "System Error" in language preferences
      DEV-10209 - reverted floater_test.xml to empty floater.
      DEV-10255 - Clicking on gestures button moves open windows
      DEV-10046 	Pressing escape doesnt cause the chat history or inventory windows to lose focus
      DEV-10399 -- Update required version of QuickTime library to 7.4.1 for 1.19.0 Viewer
      DEV-10410 - Toggling voice causes layout problems in toolbar
      DEV-8562 - Viewer crash just after login
      DEV-10147 - "LLXmlTree parse failed" with settings_releasecandidate.xml
      DEV-9874 - Land forsale icon in menubar overlaps pushobject restriction icon
      DEV-9701 - Upload Animation window: Button missing in Stopped window state
      DEV-10355 - Client crashes when viewing the proposals tab in group information
      DEV-10521 My Landmarks dropdown list adds a repetition to EOF every time it's opened
      DEV-10496 Groups>Proposals>Past Vote text gets chomped
      DEV-10499 Defaulted buttons in floater dialogs remain highlighted when not in focus
      DEV-5611 - Crash reporter appears in the background on mac (Changed launch to use open instead of direct binary call)
      DEV-10704 - Crash reporter not initializing boolean, causing false exec_froze reporting (Added initilizer to constructor)
      903292ba
  17. Nov 20, 2007
Loading