Skip to content
Snippets Groups Projects
  1. Jul 22, 2016
  2. Jul 21, 2016
    • Nat Goodspeed's avatar
      MAINT-6584: Streamline static LLImageJ2C implementation API. · 71b593e8
      Nat Goodspeed authored
      Specifically, remove unused function pointer types CreateLLImageJ2CFunction,
      DestroyLLImageJ2CFunction and EngineInfoLLImageJ2CFunction.
      
      Also eliminate static fallbackDestroyLLImageJ2CImpl() and
      fallbackEngineInfoLLImageJ2CImpl(), leaving only static
      fallbackCreateLLImageJ2CImpl().
      
      We do need a factory function to instantiate the appropriate LLImageJ2CImpl
      subclass, so leave the fallbackCreateLLImageJ2CImpl() link seam in place.
      
      However, given that every known LLImageJ2CImpl subclass is cheap to
      instantiate, make getEngineInfo() a pure virtual method on that subclass: the
      static LLImageJ2C::getEngineInfo() method can temporarily construct an
      instance to query. While we're at it, make getEngineInfo() return std::string
      like LLImageJ2C::getEngineInfo(). It's ridiculous that
      fallbackEngineInfoLLImageJ2CImpl() implementations constructed a static
      std::string and returned its c_str(), only to have LLImageJ2C::getEngineInfo()
      construct ANOTHER std::string from the returned const char*.
      
      fallbackDestroyLLImageJ2CImpl() never did anything useful: it merely deleted
      the passed LLImageJ2CImpl subclass pointer as the specific subclass type. But
      since LLImageJ2CImpl's destructor is virtual, LLImageJ2C's destructor could
      simply delete the stored LLImageJ2CImpl*. In fact, make mImpl a
      boost::scoped_ptr<LLImageJ2CImpl> so we don't even have to delete it manually.
      71b593e8
    • Nat Goodspeed's avatar
      DRTVWR-427: Remove engineInfoLLImageJ2CKDU(), createLLImageJ2CKDU(), · f09a92f1
      Nat Goodspeed authored
      destroyLLImageJ2CKDU().
      
      These were apparently intended as simple C-style DLL entry points. But as
      nobody calls them, and as we decided against building the viewer from DLLs,
      they only clutter the code.
      f09a92f1
  3. Jul 06, 2016
  4. May 19, 2016
  5. May 10, 2016
  6. May 09, 2016
  7. May 07, 2016
  8. May 06, 2016
  9. May 05, 2016
  10. May 04, 2016
  11. May 02, 2016
  12. Apr 29, 2016
  13. Apr 28, 2016
  14. Apr 26, 2016
  15. Apr 25, 2016
  16. Apr 22, 2016
Loading