Checker: NULL_RETURNS
Function: RecoveredItemCB::fire(const LLUUID &)
File: /indra/newview/llappearancemgr.cpp

Checker: REVERSE_INULL
Function: RecoveredItemLinkCB::fire(const LLUUID &)
File: /indra/newview/llappearancemgr.cpp

For EXT-5259: Major regression in load time for new users from 1.23 to 2.0.  Moved autopopulate to after avatar appearance resolves

EXT-4387 - Possible fix.  No repro, but added an extra safety check and warning the only place in the function that it appears that something could go wrong
if we have inventory corruption and InventoryType is wearable but the wearable type bitfield is in a broken state.
-Reviewed by vir.

For EXT-4919: Initial gesture setup is wrong for new users.  Added a template-y mechanism for roundtripping an inventory fetch - hopefully could replace some gratuitous classes elsewhere as well.

EXT-4997 : Centralize right-click menu options for delete/remove link
EXT-4998 : Automatically reject double separators from right click menu

Disabled/hid delete button from COF right-click menu, also means that trash icon is disabled.
Added generalized function to remove consecutive separators from right-click menu.
Made a minor cosmetic change to have all code duplication for adding "delete" menu item instead call a common function.

For EXT-4855: Crash on onWearableAssetFetch.  Prevent late-arriving wearables from touching a deleted object.

-Reviewed by vir

When switching from one pair of pants to another we were temporarily using
an in-between state without pants as a valid rendering state. Removed a call
to removeWearable to keep your pants on until the update from COF swaps the old
pair of pants for the new. Lower body is redrawn only once lowest discard level
of new pants arrives.

Code reviewed by Bigpapi

 Checker: UNINIT_CTOR
Function: LLFoundData::LLFoundData()
File: /indra/newview/llappearancemgr.cpp

To say that we must explicitly support secondlife:///app/appearance/show

secondlife:///app/appearance - to open the My Appearance sidetray
secondlife:///app/help/{TOPIC} - to display help for a given topic

I've updated https://wiki.lindenlab.com/wiki/Viewer_2.0_SLapps

EXT-4660 : Can delete a bodypart from the COF through inventory view or WEARING tab delete key
EXT-4662 : remove leading separator from COF right-click menu
EXT-4633 : AppearanceSP trash button doesn't update enabled state correctly

Bunch of UI fixes related to the trash/delete functionality in InventoryFloater/SP and AppearanceSP "WEARING" tab.  The main idea is that we don't want to allow deletion of bodyparts and folder links from the COF by the user.

For EXT-4222: Switching outfits sometimes causes me to wear both, and show previous outfit as worn.  Postpone appearance change until wearables have resolved.

Corrected bug where saving an outfit wouldn't update the "unsaved" marker on
the UI. Also switched the UI to use a popup dialog to request the name of
the outfit being made, as we could not convey everything we needed to on the
button alone.

Code reviewed by Vir

We now show a string "(unsaved)" under the appearance panel outfit title
when the currently loaded outfit has been modified from its original state.

Tested with following conditions:
1) item added to loaded outfit
2) item removed from loaded outfit
3) item replaced in loaded outfit

Appears to work properly on login as well. Checking is a manual folder compare,
but should be fairly efficient.

XUI changes submitted by Erica

Entire diff reviewed by Vir

For EXT-3812: Inventory Loss between 1.23 to 2.0 logins.  One possible cause is broken links, which this fix will detect earlier, avoiding a needlessly alarming message

now on creating a new outfit we remove the old base folder link and replace it
with a link to the newly created outfit folder. Responsive UI FTW!

Code reviewed by Vir

For EXT-3448: New attachments detach after relog. Added a check that the only objects deleted by LLAppearanceManager are links.  Probably not the cause of disappearing objects in this bug, but a good safety feature.

--HG--
branch : avatar-pipeline

For EXT-3448: New attachments detach after relog.  This fixes the most common problem, failing to create COF link to new attachment.

--HG--
branch : avatar-pipeline

--HG--
branch : avatar-pipeline

--HG--
branch : avatar-pipeline

Cuts number of includes of llnotifications.h from 300+ to 40.

--HG--
branch : avatar-pipeline

Added appearanceSP button to toggle folder closed/open state.
Also fixed up some bugs with current outfit title placement in appearanceSP.xml
Also added a generic call for getting the current outfit folder link

Added gInventory.notifyObservers to idle callbacks so it gets triggered without explicit notifyObservers synchronization.
Added more state tracking for attachments, wearables, and links of those types, so that they're marked as changed properly.

For DEV-34652: OUTFITS (Operations) : Wear folders via drag and drop - handle untyped folder dragged to outfit

--HG--
branch : avatar-pipeline