Skip to content
Snippets Groups Projects
  1. Aug 29, 2018
  2. Sep 15, 2016
    • Nat Goodspeed's avatar
      MAINT-5232: Normalize LLSingleton subclasses. · d2c3c2f9
      Nat Goodspeed authored
      A shocking number of LLSingleton subclasses had public constructors -- and in
      several instances, were being explicitly instantiated independently of the
      LLSingleton machinery. This breaks the new LLSingleton dependency-tracking
      machinery. It seems only fair that if you say you want an LLSingleton, there
      should only be ONE INSTANCE!
      
      Introduce LLSINGLETON() and LLSINGLETON_EMPTY_CTOR() macros. These handle the
      friend class LLSingleton<whatevah>;
      and explicitly declare a private nullary constructor.
      
      To try to enforce the LLSINGLETON() convention, introduce a new pure virtual
      LLSingleton method you_must_use_LLSINGLETON_macro() which is, as you might
      suspect, defined by the macro. If you declare an LLSingleton subclass without
      using LLSINGLETON() or LLSINGLETON_EMPTY_CTOR() in the class body, you can't
      instantiate the subclass for lack of a you_must_use_LLSINGLETON_macro()
      implementation -- which will hopefully remind the coder.
      
      Trawl through ALL LLSingleton subclass definitions, sprinkling in
      LLSINGLETON() or LLSINGLETON_EMPTY_CTOR() as appropriate. Remove all explicit
      constructor declarations, public or private, along with relevant 'friend class
      LLSingleton<myself>' declarations. Where destructors are declared, move them
      into private section as well. Where the constructor was inline but nontrivial,
      move out of class body.
      
      Fix several LLSingleton abuses revealed by making ctors/dtors private:
      
      LLGlobalEconomy was both an LLSingleton and the base class for
      LLRegionEconomy, a non-LLSingleton. (Therefore every LLRegionEconomy instance
      contained another instance of the LLGlobalEconomy "singleton.") Extract
      LLBaseEconomy; LLGlobalEconomy is now a trivial subclass of that.
      LLRegionEconomy, as you might suspect, now derives from LLBaseEconomy.
      
      LLToolGrab, an LLSingleton, was also explicitly instantiated by
      LLToolCompGun's constructor. Extract LLToolGrabBase, explicitly instantiated,
      with trivial subclass LLToolGrab, the LLSingleton instance.
      
      (WARNING: LLToolGrabBase methods have an unnerving tendency to go after
      LLToolGrab::getInstance(). I DO NOT KNOW what should be the relationship
      between the instance in LLToolCompGun and the LLToolGrab singleton instance.)
      
      LLGridManager declared a variant constructor accepting (const std::string&),
      with the comment:
      // initialize with an explicity grid file for testing.
      As there is no evidence of this being called from anywhere, delete it.
      
      LLChicletBar's constructor accepted an optional (const LLSD&). As the LLSD
      parameter wasn't used, and as there is no evidence of it being passed from
      anywhere, delete the parameter.
      
      LLViewerWindow::shutdownViews() was checking LLNavigationBar::
      instanceExists(), then deleting its getInstance() pointer -- leaving a
      dangling LLSingleton instance pointer, a land mine if any subsequent code
      should attempt to reference it. Use deleteSingleton() instead.
      
      ~LLAppViewer() was calling LLViewerEventRecorder::instance() and then
      explicitly calling ~LLViewerEventRecorder() on that instance -- leaving the
      LLSingleton instance pointer pointing to an allocated-but-destroyed instance.
      Use deleteSingleton() instead.
      d2c3c2f9
  3. Nov 10, 2015
  4. Mar 17, 2015
    • pavelk_productengine's avatar
      MAINT-4734 (Separate transaction notices from group notice/invites) · b147d659
      pavelk_productengine authored
       1) stripped off attachment field;
       2) made logos (group's, sender's, etc) in expanded view the same size as in condensed view;
       3) turned on notification showing upon click;
       4) fixed cropped right border of Invite and Transactions notifications;
       5) enabled "Collapse All" button;
       6) stripped off unnecessary icons.
      b147d659
  5. Jan 09, 2015
  6. Oct 18, 2014
  7. Aug 09, 2013
  8. Mar 29, 2013
  9. Dec 18, 2012
  10. Dec 03, 2012
  11. Nov 28, 2012
  12. Nov 14, 2012
  13. Nov 09, 2012
    • AlexanderP ProductEngine's avatar
      CHUI-337 FIXED: To avoid confusion with a classes "...conversation..." and in... · 486bdf32
      AlexanderP ProductEngine authored
      CHUI-337 FIXED: To avoid confusion with a classes "...conversation..." and in accordance with the naming convention in the project, some classes and corresponding files should be renamed:
      LLIMConversation -> LLFloaterIMSessionTab
      LLIMFloater -> LLFloaterIMSession
      LLNearbyChat -> LLFloaterIMNearbyChat
      LLIMFloaterContainer -> LLFloaterIMContainer
      LLNearbyChatBarListener -> LLFloaterIMNearbyChatListener
      LLNearbyChatHandler -> LLFloaterIMNearbyChatHandler
      486bdf32
  14. Oct 31, 2012
  15. Jun 27, 2012
  16. Jun 20, 2012
  17. Jun 19, 2012
  18. Jun 06, 2012
    • Seth ProductEngine's avatar
      CHUI-120 WIP Added starting ad hoc conference in the same floater as P2P chat,... · d11f542f
      Seth ProductEngine authored
      CHUI-120 WIP Added starting ad hoc conference in the same floater as P2P chat, after adding more participants.
      - Added a parameter to LLAvatarActions::startConference() and LLIMMgr::addSession() to pass the uuid of a P2P IM floater which should be used to start a new conference in it.
      - In LLChicletBar::sessionRemoved() we don't close the IM floater if it is going to be re-used for a new conference.
      d11f542f
  19. Jan 19, 2012
  20. Jan 16, 2012
  21. Dec 02, 2011
  22. Nov 25, 2011
  23. Oct 10, 2011
Loading