Skip to content
Snippets Groups Projects
  1. Dec 30, 2020
  2. Oct 20, 2020
  3. Sep 28, 2020
  4. Jul 03, 2020
  5. Mar 21, 2020
  6. Mar 11, 2020
  7. Jan 29, 2018
  8. Mar 07, 2016
  9. Feb 03, 2016
  10. Jan 28, 2016
  11. Jan 26, 2016
  12. Nov 10, 2015
  13. Mar 29, 2013
  14. Oct 14, 2011
  15. Feb 05, 2011
    • Aleric Inglewood's avatar
      Introduces a LLThreadLocalData class that can be · ef490e30
      Aleric Inglewood authored
      accessed through the static LLThread::tldata().
      Currently this object contains two (public) thread-local
      objects: a LLAPRRootPool and a LLVolatileAPRPool.
      
      The first is the general memory pool used by this thread
      (and this thread alone), while the second is intended
      for short lived memory allocations (needed for APR).
      The advantages of not mixing those two is that the latter
      is used most frequently, and as a result of it's nature
      can be destroyed and reconstructed on a "regular" basis.
      
      This patch adds LLAPRPool (completely replacing the old one),
      which is a wrapper around apr_pool_t* and has complete
      thread-safity checking.
      
      Whenever an apr call requires memory for some resource,
      a memory pool in the form of an LLAPRPool object can
      be created with the same life-time as this resource;
      assuring clean up of the memory no sooner, but also
      not much later than the life-time of the resource
      that needs the memory.
      
      Many, many function calls and constructors had the
      pool parameter simply removed (it is no longer the
      concern of the developer, if you don't write code
      that actually does an libapr call then you are no
      longer bothered with memory pools at all).
      
      However, I kept the notion of short-lived and
      long-lived allocations alive (see my remark in
      the jira here: https://jira.secondlife.com/browse/STORM-864?focusedCommentId=235356&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-235356
      which requires that the LLAPRFile API needs
      to allow the user to specify how long they
      think a file will stay open. By choosing
      'short_lived' as default for the constructor
      that immediately opens a file, the number of
      instances where this needs to be specified is
      drastically reduced however (obviously, any
      automatic LLAPRFile is short lived).
      
      ***
      
      Addressed Boroondas remarks in https://codereview.secondlife.com/r/99/
      regarding (doxygen) comments. This patch effectively only changes comments.
      
      Includes some 'merge' stuff that ended up in llvocache.cpp
      (while starting as a bug fix, now only resulting in a cleanup).
      
      ***
      
      Added comment 'The use of apr_pool_t is OK here'.
      
      Added this comment on every line where apr_pool_t
      is correctly being used.
      
      This should make it easier to spot (future) errors
      where someone started to use apr_pool_t; you can
      just grep all sources for 'apr_pool_t' and immediately
      see where it's being used while LLAPRPool should
      have been used.
      
      Note that merging this patch is very easy:
      If there are no other uses of apr_pool_t in the code
      (one grep) and it compiles, then it will work.
      
      ***
      
      Second Merge (needed to remove 'delete mCreationMutex'
      from LLImageDecodeThread::~LLImageDecodeThread).
      
      ***
      
      Added back #include <apr_pools.h>.
      
      Apparently that is needed on libapr version 1.2.8.,
      the version used by Linden Lab, for calls to
      apr_queue_*. This is a bug in libapr (we also
      include <apr_queue.h>, that is fixed in (at least) 1.3.7.
      
      Note that 1.2.8 is VERY old. Even 1.3.x is old.
      
      ***
      
      License fixes (GPL -> LGPL). And typo in comments.
      Addresses merov's comments on the review board.
      
      ***
      
      Added Merov's compile fixes for windows.
      ef490e30
  16. Oct 13, 2010
  17. Sep 21, 2010
  18. Aug 13, 2010
  19. Nov 13, 2009
  20. Jun 21, 2009
  21. May 22, 2009
    • Brad Kittenbrink's avatar
      DEV-27646 dll linkage for login module. · 01d39082
      Brad Kittenbrink authored
      Ok, finally got this to a point where it doesn't break the build and I can check
      in. llcommon can be built as a shared library (disabled but can be enabled with
      cmake cache var LLCOMMON_LINK_SHARED.
      
      reviewed by Mani on tuesday (I still need to get his suggested changes
      re-reviewed)
      01d39082
  22. May 08, 2009
  23. Jan 07, 2009
  24. Oct 04, 2007
  25. Mar 02, 2007
  26. Jan 02, 2007
Loading