Skip to content
Snippets Groups Projects
  1. Jul 11, 2021
  2. Jan 31, 2021
  3. Sep 26, 2020
  4. Sep 25, 2020
  5. Sep 18, 2020
  6. Sep 17, 2020
  7. Jul 29, 2020
  8. Jul 05, 2020
  9. Mar 25, 2020
    • Nat Goodspeed's avatar
      DRTVWR-494: Defend LLInstanceTracker against multi-thread usage. · 9d5b8976
      Nat Goodspeed authored
      The previous implementation went to some effort to crash if anyone attempted
      to create or destroy an LLInstanceTracker subclass instance during traversal.
      That restriction is manageable within a single thread, but becomes unworkable
      if it's possible that a given subclass might be used on more than one thread.
      
      Remove LLInstanceTracker::instance_iter, beginInstances(), endInstances(),
      also key_iter, beginKeys() and endKeys(). Instead, introduce key_snapshot()
      and instance_snapshot(), the only means of iterating over LLInstanceTracker
      instances. (These are intended to resemble functions, but in fact the current
      implementation simply presents the classes.) Iterating over a captured
      snapshot defends against container modifications during traversal. The term
      'snapshot' reminds the coder that a new instance created during traversal will
      not be considered. To defend against instance deletion during traversal, a
      snapshot stores std::weak_ptrs which it lazily dereferences, skipping on the
      fly any that have expired.
      
      Dereferencing instance_snapshot::iterator gets you a reference rather than a
      pointer. Because some use cases want to delete all existing instances, add an
      instance_snapshot::deleteAll() method that extracts the pointer. Those cases
      used to require explicitly copying instance pointers into a separate
      container; instance_snapshot() now takes care of that. It remains the caller's
      responsibility to ensure that all instances of that LLInstanceTracker subclass
      were allocated on the heap.
      
      Replace unkeyed static LLInstanceTracker::getInstance(T*) -- which returned
      nullptr if that instance had been destroyed -- with new getWeak() method
      returning std::weak_ptr<T>. Caller must detect expiration of that weak_ptr.
      
      Adjust tests accordingly.
      
      Use of std::weak_ptr to detect expired instances requires engaging
      std::shared_ptr in the constructor. We now store shared_ptrs in the static
      containers (std::map for keyed, std::set for unkeyed).
      
      Make LLInstanceTrackerBase a template parameterized on the type of the static
      data it manages. For that reason, hoist static data class declarations out of
      the class definitions to an LLInstanceTrackerStuff namespace.
      
      Remove the static atomic sIterationNestDepth and its methods incrementDepth(),
      decrementDepth() and getDepth(), since they were used only to forbid creation
      and destruction during traversal.
      
      Add a std::mutex to static data. Introduce an internal LockStatic class that
      locks the mutex while providing a pointer to static data, making that the only
      way to access the static data.
      
      The LLINSTANCETRACKER_DTOR_NOEXCEPT macro goes away because we no longer
      expect ~LLInstanceTracker() to throw an exception in test programs.
      That affects LLTrace::StatBase as well as LLInstanceTracker itself.
      
      Adapt consumers to the new LLInstanceTracker API.
      9d5b8976
  10. Mar 19, 2020
  11. Mar 13, 2020
  12. Aug 10, 2019
  13. Nov 10, 2015
  14. Oct 17, 2014
  15. Apr 30, 2013
  16. Mar 29, 2013
  17. Mar 12, 2013
  18. Oct 10, 2012
  19. Jul 26, 2011
    • Richard Nelson's avatar
      EXP-1021 FIX Position of web content browser dictates position of profile... · fd9f3b9f
      Richard Nelson authored
      EXP-1021 FIX Position of web content browser dictates position of profile panel - profile panel position changes do not persist
      EXP-1030 FIX Search button toggle can get out of synch in bottom bar
      made llinstancetracker::iterator do own nested level management (removing need for separate guard)
      added support for filename= to floaters
      can pass in arbitrary window_class to floaters
      fd9f3b9f
  20. Jun 15, 2011
  21. Oct 13, 2010
  22. Sep 21, 2010
  23. Aug 13, 2010
  24. Feb 17, 2010
  25. Feb 10, 2010
  26. Feb 02, 2010
  27. Jan 29, 2010
    • Tofu Linden's avatar
      CID-345 · 5c01eca7
      Tofu Linden authored
      Checker: UNINIT_CTOR
      Function: LLConsole::LLConsole(const LLConsole::Params &)
      File: /indra/llui/llconsole.cpp
      5c01eca7
  28. Jan 08, 2010
    • James Cook's avatar
      First pass expose inventory item settings in XML (folder_view_item.xml) · 9ffaacc4
      James Cook authored
      Optimized LLFolderViewItem constructor by passing param block as
      const ref to avoid copies.
      Removed per-item arrow and background images, use defaults.
      Removed unneeded static image pointers.
      Removed hard-coded rounded_square.tga, replaced with Rounded_Square
      Ditto for folder_arrow.tga
      Reviewed with Richard.
      9ffaacc4
  29. Jan 06, 2010
  30. Jan 04, 2010
  31. Nov 24, 2009
  32. Nov 09, 2009
  33. Oct 15, 2009
  34. Oct 03, 2009
  35. Jul 06, 2009
  36. Jun 21, 2009
  37. May 08, 2009
Loading