Skip to content
Snippets Groups Projects
  1. Mar 25, 2020
    • Nat Goodspeed's avatar
      DRTVWR-494: Move LL_ERRS out of llinstancetracker.h header file. · 2506fd78
      Nat Goodspeed authored
      Add a namespaced free function in .cpp file to report LL_ERRS as needed.
      
      Per code review, use a more indicative namespace name.
      2506fd78
    • Nat Goodspeed's avatar
      DRTVWR-494: Defend LLInstanceTracker against multi-thread usage. · 9d5b8976
      Nat Goodspeed authored
      The previous implementation went to some effort to crash if anyone attempted
      to create or destroy an LLInstanceTracker subclass instance during traversal.
      That restriction is manageable within a single thread, but becomes unworkable
      if it's possible that a given subclass might be used on more than one thread.
      
      Remove LLInstanceTracker::instance_iter, beginInstances(), endInstances(),
      also key_iter, beginKeys() and endKeys(). Instead, introduce key_snapshot()
      and instance_snapshot(), the only means of iterating over LLInstanceTracker
      instances. (These are intended to resemble functions, but in fact the current
      implementation simply presents the classes.) Iterating over a captured
      snapshot defends against container modifications during traversal. The term
      'snapshot' reminds the coder that a new instance created during traversal will
      not be considered. To defend against instance deletion during traversal, a
      snapshot stores std::weak_ptrs which it lazily dereferences, skipping on the
      fly any that have expired.
      
      Dereferencing instance_snapshot::iterator gets you a reference rather than a
      pointer. Because some use cases want to delete all existing instances, add an
      instance_snapshot::deleteAll() method that extracts the pointer. Those cases
      used to require explicitly copying instance pointers into a separate
      container; instance_snapshot() now takes care of that. It remains the caller's
      responsibility to ensure that all instances of that LLInstanceTracker subclass
      were allocated on the heap.
      
      Replace unkeyed static LLInstanceTracker::getInstance(T*) -- which returned
      nullptr if that instance had been destroyed -- with new getWeak() method
      returning std::weak_ptr<T>. Caller must detect expiration of that weak_ptr.
      
      Adjust tests accordingly.
      
      Use of std::weak_ptr to detect expired instances requires engaging
      std::shared_ptr in the constructor. We now store shared_ptrs in the static
      containers (std::map for keyed, std::set for unkeyed).
      
      Make LLInstanceTrackerBase a template parameterized on the type of the static
      data it manages. For that reason, hoist static data class declarations out of
      the class definitions to an LLInstanceTrackerStuff namespace.
      
      Remove the static atomic sIterationNestDepth and its methods incrementDepth(),
      decrementDepth() and getDepth(), since they were used only to forbid creation
      and destruction during traversal.
      
      Add a std::mutex to static data. Introduce an internal LockStatic class that
      locks the mutex while providing a pointer to static data, making that the only
      way to access the static data.
      
      The LLINSTANCETRACKER_DTOR_NOEXCEPT macro goes away because we no longer
      expect ~LLInstanceTracker() to throw an exception in test programs.
      That affects LLTrace::StatBase as well as LLInstanceTracker itself.
      
      Adapt consumers to the new LLInstanceTracker API.
      9d5b8976
  2. Jan 15, 2019
  3. Nov 10, 2015
  4. Oct 18, 2013
  5. Apr 24, 2013
  6. Apr 19, 2013
  7. Apr 15, 2013
  8. Mar 29, 2013
  9. Mar 11, 2013
  10. Mar 07, 2013
  11. Feb 28, 2013
  12. Dec 23, 2012
  13. Sep 06, 2011
    • Nat Goodspeed's avatar
      STORM-1541: Hoist LLInstanceTracker::getMap_() to base getStatic(). · 8c6f7529
      Nat Goodspeed authored
      Generalize the notion of getting some chunk of "static" storage: introduce
      LLInstanceTrackerBase::getStatic() template method. Define StaticData struct
      containing the InstanceMap (or InstanceSet, for that specialization) along
      with the S32 that caused the VS2010 linker so much grief. Completely eliminate
      that S32 as an actual class-static member, qualifying all references with the
      struct returned by getStatic().
      In LLInstanceTrackerBase::getInstances(), use one std::map lookup instead of
      three.
      8c6f7529
  14. Mar 09, 2011
  15. Oct 13, 2010
  16. Sep 21, 2010
  17. Aug 13, 2010
  18. Feb 06, 2010
  19. Jun 04, 2009
  20. May 08, 2009
Loading