Skip to content
Snippets Groups Projects
  1. Jul 21, 2020
    • Nicky Dasmijn's avatar
      Remove redundant LL_EXSTAT_ from enums. · fba9abbb
      Nicky Dasmijn authored
      fba9abbb
    • Nicky Dasmijn's avatar
      LLExtStat had been a S32, this wasn't right, as some of the constants lead to... · acaa2723
      Nicky Dasmijn authored
      LLExtStat had been a S32, this wasn't right, as some of the constants lead to integer overflow: const LLExtStat LL_EXSTAT_RES_RESULT = 2L<<30; const LLExtStat LL_EXSTAT_VFS_RESULT = 3L<<30; This shifts into the sign bit and clang gets (rightfully) upset about this.
      
      LLExtStatus needs to be at least of type U32 to remedy this problem, but
      while at it it makes sense to turn it into what it is: An enum. Turning
      it into a class enum has the added benefit we get type safety for mostly
      free.
      Which incidentally turned up a problem right away:
      A call to removeAndCallbackPendingDownloads had status and extstatus
      reversed and thus was wrong.
      acaa2723
  2. Feb 10, 2016
  3. Nov 10, 2015
  4. Aug 09, 2013
  5. Mar 29, 2013
  6. Oct 13, 2010
  7. Sep 21, 2010
  8. Aug 13, 2010
  9. Jan 07, 2009
  10. Oct 04, 2007
  11. Aug 21, 2007
  12. Mar 02, 2007
  13. Jan 17, 2007
  14. Jan 02, 2007
Loading