Skip to content
Snippets Groups Projects
  1. Apr 10, 2019
  2. Dec 14, 2017
  3. May 15, 2017
  4. May 04, 2017
  5. Feb 15, 2017
  6. May 17, 2017
  7. Sep 15, 2016
    • Nat Goodspeed's avatar
      MAINT-5232: Normalize LLSingleton subclasses. · d2c3c2f9
      Nat Goodspeed authored
      A shocking number of LLSingleton subclasses had public constructors -- and in
      several instances, were being explicitly instantiated independently of the
      LLSingleton machinery. This breaks the new LLSingleton dependency-tracking
      machinery. It seems only fair that if you say you want an LLSingleton, there
      should only be ONE INSTANCE!
      
      Introduce LLSINGLETON() and LLSINGLETON_EMPTY_CTOR() macros. These handle the
      friend class LLSingleton<whatevah>;
      and explicitly declare a private nullary constructor.
      
      To try to enforce the LLSINGLETON() convention, introduce a new pure virtual
      LLSingleton method you_must_use_LLSINGLETON_macro() which is, as you might
      suspect, defined by the macro. If you declare an LLSingleton subclass without
      using LLSINGLETON() or LLSINGLETON_EMPTY_CTOR() in the class body, you can't
      instantiate the subclass for lack of a you_must_use_LLSINGLETON_macro()
      implementation -- which will hopefully remind the coder.
      
      Trawl through ALL LLSingleton subclass definitions, sprinkling in
      LLSINGLETON() or LLSINGLETON_EMPTY_CTOR() as appropriate. Remove all explicit
      constructor declarations, public or private, along with relevant 'friend class
      LLSingleton<myself>' declarations. Where destructors are declared, move them
      into private section as well. Where the constructor was inline but nontrivial,
      move out of class body.
      
      Fix several LLSingleton abuses revealed by making ctors/dtors private:
      
      LLGlobalEconomy was both an LLSingleton and the base class for
      LLRegionEconomy, a non-LLSingleton. (Therefore every LLRegionEconomy instance
      contained another instance of the LLGlobalEconomy "singleton.") Extract
      LLBaseEconomy; LLGlobalEconomy is now a trivial subclass of that.
      LLRegionEconomy, as you might suspect, now derives from LLBaseEconomy.
      
      LLToolGrab, an LLSingleton, was also explicitly instantiated by
      LLToolCompGun's constructor. Extract LLToolGrabBase, explicitly instantiated,
      with trivial subclass LLToolGrab, the LLSingleton instance.
      
      (WARNING: LLToolGrabBase methods have an unnerving tendency to go after
      LLToolGrab::getInstance(). I DO NOT KNOW what should be the relationship
      between the instance in LLToolCompGun and the LLToolGrab singleton instance.)
      
      LLGridManager declared a variant constructor accepting (const std::string&),
      with the comment:
      // initialize with an explicity grid file for testing.
      As there is no evidence of this being called from anywhere, delete it.
      
      LLChicletBar's constructor accepted an optional (const LLSD&). As the LLSD
      parameter wasn't used, and as there is no evidence of it being passed from
      anywhere, delete the parameter.
      
      LLViewerWindow::shutdownViews() was checking LLNavigationBar::
      instanceExists(), then deleting its getInstance() pointer -- leaving a
      dangling LLSingleton instance pointer, a land mine if any subsequent code
      should attempt to reference it. Use deleteSingleton() instead.
      
      ~LLAppViewer() was calling LLViewerEventRecorder::instance() and then
      explicitly calling ~LLViewerEventRecorder() on that instance -- leaving the
      LLSingleton instance pointer pointing to an allocated-but-destroyed instance.
      Use deleteSingleton() instead.
      d2c3c2f9
  8. Aug 29, 2016
  9. Apr 11, 2016
  10. Mar 02, 2016
  11. Nov 10, 2015
  12. Mar 16, 2015
  13. Jan 16, 2015
  14. May 23, 2014
  15. May 06, 2014
  16. Mar 26, 2014
  17. Nov 25, 2013
  18. Aug 29, 2013
  19. Aug 09, 2013
  20. Jul 30, 2013
  21. Jul 29, 2013
  22. Jun 06, 2013
  23. Jun 05, 2013
  24. Mar 12, 2013
  25. Feb 22, 2013
  26. Jan 29, 2013
  27. Jan 25, 2013
  28. Jan 24, 2013
  29. Jan 18, 2013
  30. Jan 11, 2013
  31. Dec 17, 2012
  32. Dec 14, 2012
  33. Dec 05, 2012
  34. Nov 27, 2012
  35. Nov 20, 2012
  36. Nov 09, 2012
    • AlexanderP ProductEngine's avatar
      CHUI-337 FIXED: To avoid confusion with a classes "...conversation..." and in... · 486bdf32
      AlexanderP ProductEngine authored
      CHUI-337 FIXED: To avoid confusion with a classes "...conversation..." and in accordance with the naming convention in the project, some classes and corresponding files should be renamed:
      LLIMConversation -> LLFloaterIMSessionTab
      LLIMFloater -> LLFloaterIMSession
      LLNearbyChat -> LLFloaterIMNearbyChat
      LLIMFloaterContainer -> LLFloaterIMContainer
      LLNearbyChatBarListener -> LLFloaterIMNearbyChatListener
      LLNearbyChatHandler -> LLFloaterIMNearbyChatHandler
      486bdf32
  37. Nov 08, 2012
  38. Oct 26, 2012
    • Gilbert Gonzales's avatar
      CHUI-383: Realized that prior changes for this bug caused a regress. The... · 1a1a0b91
      Gilbert Gonzales authored
      CHUI-383: Realized that prior changes for this bug caused a regress. The regress was using the people panel or a notecard to start a im/call with a user. When doing this the conversation line item would not be focused. Resolution: Changed all calls to LLIMFloater::show() to LLIMFloaterContainer::showConversation(), which will first select the conversation line item and then show the corresponding conversation floater.
      1a1a0b91
  39. Oct 17, 2012
Loading