Skip to content
Snippets Groups Projects
  1. Sep 26, 2018
  2. Aug 29, 2018
  3. Aug 28, 2018
  4. Aug 17, 2018
  5. Jun 28, 2018
    • Nat Goodspeed's avatar
      DRTVWR-447: Suppress BugSplat UI; auto-fill certain BugSplat data. · cd52724e
      Nat Goodspeed authored
      Direct BugSplat to send crash reports without prompting, on both Windows and
      Mac.
      
      Add a mechanism by which code called after LL_ERRS() can retrieve the fatal
      log message string. (How did the crash logger extract that for Linden crash
      logging?)
      
      Add that fatal message to crash reports on Windows. But as BugsplatMac is
      engaged only on the run _after_ the crash, we no longer have that message in
      memory.
      
      Also add user name and region location to Windows crash reports. On Mac, (a)
      we don't have the information from the previous run and (b) BugsplatMac
      doesn't provide an API to attach that information to the crash report.
      
      Add Mac logging to indicate the success or failure of sending the crash
      report. Add Windows logging to indicate we're about to send.
      cd52724e
  6. Jun 07, 2018
  7. Jun 06, 2018
  8. Jul 24, 2017
  9. Jun 20, 2017
  10. Mar 13, 2017
    • Nat Goodspeed's avatar
      DRTVWR-418: Ignore logging that requires resurrecting singletons. · 1a8c8df6
      Nat Goodspeed authored
      The logging subsystem depends on two different LLSingletons for some reason.
      It turns out to be very difficult to completely avoid executing any logging
      calls after the LLSingletonBase::deleteAll(), but we really don't want to
      resurrect those LLSingletons so late in the run for a couple stragglers.
      Introduce LLSingleton::wasDeleted() query method, and use it in logging
      subsystem to simply bypass last-millisecond logging requests.
      1a8c8df6
  11. Mar 09, 2017
  12. Mar 03, 2017
  13. Feb 27, 2017
  14. Oct 11, 2016
  15. Oct 10, 2016
  16. Sep 28, 2016
  17. Sep 17, 2016
    • Nat Goodspeed's avatar
      MAINT-5232: Eliminate pointless string search for "class " prefix. · d0249fb7
      Nat Goodspeed authored
      The Visual C++ runtime produces typeid(MyClass).name() as "class MyClass".
      It's prudent to check for the presence of that prefix before stripping off the
      first six characters, but if the first comparison should ever fail, find()
      would continue searching the rest of the string for "class " -- a search
      guaranteed to fail. Use compare() instead.
      d0249fb7
  18. Sep 15, 2016
    • Nat Goodspeed's avatar
      MAINT-5232: Normalize LLSingleton subclasses. · d2c3c2f9
      Nat Goodspeed authored
      A shocking number of LLSingleton subclasses had public constructors -- and in
      several instances, were being explicitly instantiated independently of the
      LLSingleton machinery. This breaks the new LLSingleton dependency-tracking
      machinery. It seems only fair that if you say you want an LLSingleton, there
      should only be ONE INSTANCE!
      
      Introduce LLSINGLETON() and LLSINGLETON_EMPTY_CTOR() macros. These handle the
      friend class LLSingleton<whatevah>;
      and explicitly declare a private nullary constructor.
      
      To try to enforce the LLSINGLETON() convention, introduce a new pure virtual
      LLSingleton method you_must_use_LLSINGLETON_macro() which is, as you might
      suspect, defined by the macro. If you declare an LLSingleton subclass without
      using LLSINGLETON() or LLSINGLETON_EMPTY_CTOR() in the class body, you can't
      instantiate the subclass for lack of a you_must_use_LLSINGLETON_macro()
      implementation -- which will hopefully remind the coder.
      
      Trawl through ALL LLSingleton subclass definitions, sprinkling in
      LLSINGLETON() or LLSINGLETON_EMPTY_CTOR() as appropriate. Remove all explicit
      constructor declarations, public or private, along with relevant 'friend class
      LLSingleton<myself>' declarations. Where destructors are declared, move them
      into private section as well. Where the constructor was inline but nontrivial,
      move out of class body.
      
      Fix several LLSingleton abuses revealed by making ctors/dtors private:
      
      LLGlobalEconomy was both an LLSingleton and the base class for
      LLRegionEconomy, a non-LLSingleton. (Therefore every LLRegionEconomy instance
      contained another instance of the LLGlobalEconomy "singleton.") Extract
      LLBaseEconomy; LLGlobalEconomy is now a trivial subclass of that.
      LLRegionEconomy, as you might suspect, now derives from LLBaseEconomy.
      
      LLToolGrab, an LLSingleton, was also explicitly instantiated by
      LLToolCompGun's constructor. Extract LLToolGrabBase, explicitly instantiated,
      with trivial subclass LLToolGrab, the LLSingleton instance.
      
      (WARNING: LLToolGrabBase methods have an unnerving tendency to go after
      LLToolGrab::getInstance(). I DO NOT KNOW what should be the relationship
      between the instance in LLToolCompGun and the LLToolGrab singleton instance.)
      
      LLGridManager declared a variant constructor accepting (const std::string&),
      with the comment:
      // initialize with an explicity grid file for testing.
      As there is no evidence of this being called from anywhere, delete it.
      
      LLChicletBar's constructor accepted an optional (const LLSD&). As the LLSD
      parameter wasn't used, and as there is no evidence of it being passed from
      anywhere, delete the parameter.
      
      LLViewerWindow::shutdownViews() was checking LLNavigationBar::
      instanceExists(), then deleting its getInstance() pointer -- leaving a
      dangling LLSingleton instance pointer, a land mine if any subsequent code
      should attempt to reference it. Use deleteSingleton() instead.
      
      ~LLAppViewer() was calling LLViewerEventRecorder::instance() and then
      explicitly calling ~LLViewerEventRecorder() on that instance -- leaving the
      LLSingleton instance pointer pointing to an allocated-but-destroyed instance.
      Use deleteSingleton() instead.
      d2c3c2f9
  19. Sep 03, 2016
    • Nat Goodspeed's avatar
      MAINT-5232: Make LLError::is_available() depend on both LLSingletons. · 4af7e496
      Nat Goodspeed authored
      LLError machinery depends on two different LLSingletons. Its is_available()
      function is primarily for LLSingleton itself to determine whether it is, or is
      not, safe to log. Until both of LLError's LLSingletons have been constructed,
      attempting to log LLSingleton operations could produce infinite recursion.
      4af7e496
  20. Nov 10, 2015
  21. Jun 26, 2015
  22. Jun 25, 2015
    • Nat Goodspeed's avatar
      MAINT-5232: Try to avoid circularity between LLError and LLSingleton. · 0ea1b2a1
      Nat Goodspeed authored
      Part of LLError's logging infrastructure is implemented with an LLSingleton.
      Therefore, attempts to log from within LLSingleton machinery could potentially
      go south if LLError's LLSingleton is not yet initialized.
      Introduce LLError::is_available() in llerrorcontrol.h and llerror.cpp.
      Make LLSingletonBase::logwarns() and logerrs() consult LLError::is_available()
      before attempting to use LL_WARNS or LL_ERRS, respectively.
      Moreover, make all LLSingleton internal logging use logwarns() and logerrs()
      instead of directly engaging LL_ERRS or LL_WARNS.
      0ea1b2a1
  23. Apr 22, 2015
  24. Apr 10, 2015
  25. Apr 07, 2015
  26. Dec 09, 2014
  27. May 16, 2014
  28. Apr 28, 2014
  29. Apr 25, 2014
  30. Mar 13, 2014
  31. Feb 20, 2014
  32. Feb 05, 2014
  33. Feb 14, 2014
Loading