Skip to content
Snippets Groups Projects

Linux - Replace legacy desktop integration with modern XDG-based integration

Closed JennaHuntsman requested to merge JennaHuntsman/xdg-integration:main into main

Replace manual placement of .desktop files with modern XDG-based install process.

Update .desktop file to leverage modern XDG functions (namely, the ability for an application to request to be ran on the system's most powerful GPU, useful for hybrid graphics setups).

Also provides provisions for launching the viewer on the iGPU and associating SLURLs via the desktop file, accessible by right-clicking the desktop shortcut.

Edited by JennaHuntsman

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ghost User
  • JennaHuntsman added 1 commit

    added 1 commit

    • 211fbb03 - Merge suggestions from @Xenny Heartsong

    Compare with previous version

  • JennaHuntsman resolved all threads

    resolved all threads

  • JennaHuntsman resolved all threads

    resolved all threads

  • Rye Mutt approved this merge request

    approved this merge request

  • Ghost User approved this merge request

    approved this merge request

  • Will remove draft status for this merge, code in it's current state is stable on the machines that I've tested.

    Likely will be revisited to investigate further development (as mentioned in the discussion on the yggdrasil #features channel).

  • JennaHuntsman marked this merge request as ready

    marked this merge request as ready

  • Contributor

    There's only one thing that bothers me still, and it's that it's currently branding itself as "Alchemy", which could be a problem if there's more than one version of the viewer installed. This is something I had to painstakingly fix on Arch Linux since there are three versions available (hopefully two in the near future) and I would rather fix it upstream than through the distribution-specific packaging script. I'd like to know @rye and @darl's stance on this before I go ham trying to implement it.

  • A quick fix for that could likely be achieved in refresh_desktop_app_entry.sh by changing the viewer name from "Alchemy" to, say, "Alchemy AgileAkita" or something (i.e. formatting using VIEWERNAME VARIANTNAME), which would change the name used by the desktop entry to distinguish between variants - although there may be another way you're thinking of?

    Edited by JennaHuntsman
  • Contributor

    That would be fine. I'm not familiar with the way these variables are used (I've honestly never seen {varname,,} before), but using the full name would likely be fine.

  • {varname,,} is Bash 4+ to convert a variable to lowercase. Nothing too fancy, just saves adding a function which would do the same. Will look into adding variants as a param.

    (Marking as draft again)

  • JennaHuntsman marked this merge request as draft

    marked this merge request as draft

  • JennaHuntsman added 1 commit

    added 1 commit

    • 76511174 - Add ability to define viewer release channel to refresh_desktop_entry.sh to...

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading