CHOP-962: Make LLControlVariable::setPersist() accept only enum.
Initial change made LLControlVariable::mPersist an enum, but retained bool/BOOL public API. setPersist(true) set one value, setPersist(false) set another, forcePersist() set the third. Per code review, expose enum to public, make setPersist() (and LLControlVariable constructor, and LLControlGroup:: declareControl(), and all the LLControlGroup::declareMumble() methods, and all the unit-test dummy declareMumble() method bodies) accept that enum. Remove forcePersist(). Fix calls to LLControlGroup::declareMumble() accordingly. Also rename PERSIST_YES to PERSIST_NONDFT, also per code review.
Showing
- indra/llui/llfloaterreg.cpp 6 additions, 6 deletionsindra/llui/llfloaterreg.cpp
- indra/llui/llnotifications.cpp 1 addition, 1 deletionindra/llui/llnotifications.cpp
- indra/llxml/llcontrol.cpp 36 additions, 39 deletionsindra/llxml/llcontrol.cpp
- indra/llxml/llcontrol.h 20 additions, 22 deletionsindra/llxml/llcontrol.h
- indra/newview/llagent.cpp 1 addition, 1 deletionindra/newview/llagent.cpp
- indra/newview/llfloaterimnearbychat.cpp 1 addition, 1 deletionindra/newview/llfloaterimnearbychat.cpp
- indra/newview/tests/llagentaccess_test.cpp 6 additions, 6 deletionsindra/newview/tests/llagentaccess_test.cpp
- indra/newview/tests/lllogininstance_test.cpp 9 additions, 9 deletionsindra/newview/tests/lllogininstance_test.cpp
- indra/newview/tests/llsecapi_test.cpp 1 addition, 1 deletionindra/newview/tests/llsecapi_test.cpp
- indra/newview/tests/llsechandler_basic_test.cpp 1 addition, 1 deletionindra/newview/tests/llsechandler_basic_test.cpp
- indra/newview/tests/llslurl_test.cpp 1 addition, 1 deletionindra/newview/tests/llslurl_test.cpp
- indra/newview/tests/llviewerhelputil_test.cpp 1 addition, 1 deletionindra/newview/tests/llviewerhelputil_test.cpp
- indra/newview/tests/llviewernetwork_test.cpp 1 addition, 1 deletionindra/newview/tests/llviewernetwork_test.cpp
- indra/newview/tests/llxmlrpclistener_test.cpp 2 additions, 2 deletionsindra/newview/tests/llxmlrpclistener_test.cpp
Loading
Please register or sign in to comment