Skip to content
Snippets Groups Projects
  • Andrew Productengine's avatar
    f4d713ad
    STORM-404 FIXED Fixed crash in LLPanelGroupGeneral::updateMembers(). · f4d713ad
    Andrew Productengine authored
    Crash happened when trying to create new group while other group was still updating. It was caused by invalid iterator mMemberProgress in LLPanelGroupGeneral::updateMembers().
    Its usage shouldn't have been reached when member list is cleared and empty thanking to gdatap->isMemberDataComplete() check at the beginning of the function. But when the new group was created while members of other group were still updating this
    protection failed: in LLGroupMgr::processGroupMembersReply() for the group being created mMemberDataComplete was set TRUE when group size was zero(because this new group still
    had no members). So the check for completness in LLPanelGroupGeneral::updateMembers() was succesfully passed, and further in this method viewer crashed.
    
    - Added check for emptiness of member list into LLPanelGroupGeneral::updateMembers().
    f4d713ad
    History
    STORM-404 FIXED Fixed crash in LLPanelGroupGeneral::updateMembers().
    Andrew Productengine authored
    Crash happened when trying to create new group while other group was still updating. It was caused by invalid iterator mMemberProgress in LLPanelGroupGeneral::updateMembers().
    Its usage shouldn't have been reached when member list is cleared and empty thanking to gdatap->isMemberDataComplete() check at the beginning of the function. But when the new group was created while members of other group were still updating this
    protection failed: in LLGroupMgr::processGroupMembersReply() for the group being created mMemberDataComplete was set TRUE when group size was zero(because this new group still
    had no members). So the check for completness in LLPanelGroupGeneral::updateMembers() was succesfully passed, and further in this method viewer crashed.
    
    - Added check for emptiness of member list into LLPanelGroupGeneral::updateMembers().
Code owners
Assign users and groups as approvers for specific file changes. Learn more.