Skip to content
Snippets Groups Projects
  • Nat Goodspeed's avatar
    132e708f
    SL-10153: Fix previous commit for non-Windows systems. · 132e708f
    Nat Goodspeed authored
    Move Windows-flavored llstring_getoptenv() to Windows-specific section of
    llstring.cpp.
    
    boost::optional type must be stated explicitly to initialize with a value.
    
    On platforms where llwchar is the same as wchar_t, LLWString is the same as
    std::wstring, so ll_convert specializations for std::wstring would duplicate
    those for LLWString. Defend against that.
    
    The compilers we use don't like 'return condition? { expr } : {}', in which we
    hope to construct and return an instance of the declared return type without
    having to restate the type. It works to use an explicit 'if' statement.
    132e708f
    History
    SL-10153: Fix previous commit for non-Windows systems.
    Nat Goodspeed authored
    Move Windows-flavored llstring_getoptenv() to Windows-specific section of
    llstring.cpp.
    
    boost::optional type must be stated explicitly to initialize with a value.
    
    On platforms where llwchar is the same as wchar_t, LLWString is the same as
    std::wstring, so ll_convert specializations for std::wstring would duplicate
    those for LLWString. Defend against that.
    
    The compilers we use don't like 'return condition? { expr } : {}', in which we
    hope to construct and return an instance of the declared return type without
    having to restate the type. It works to use an explicit 'if' statement.
Code owners
Assign users and groups as approvers for specific file changes. Learn more.