Skip to content
Snippets Groups Projects
  • Vadim Savchuk's avatar
    b7d0bb9e
    Fixed bug EXT-6399 (System locale is the same for all languages). · b7d0bb9e
    Vadim Savchuk authored
    Problem:
    * English locale was set for all languages.
    * Specifying a correct locale didn't affect anything, including date/time formatting.
    
    My investigation has shown that LLStringUtil was instantiated twice: in the
    main binary and in libllcommon.so.
    Because LLStringUtil::setLocale() was called from newview and getLocale()
    was called from llcommon, they effectively used *different* instances of
    LLStringUtil::sLocale. Hence getLocale() always returned empty string.
    
    This seems to be caused by get/setLocale() methods not being dllexported.
    
    The fix instantiates get/setLocale() and sLocale in llcommon and exposes
    them to use from newview (i.e. prevents multiple instantiation).
    
    Besides, I specified correct locale names for all languages and platforms.
    
    Reviewed by Leyla: https://codereview.productengine.com/secondlife/r/104/
    
    --HG--
    branch : product-engine
    b7d0bb9e
    History
    Fixed bug EXT-6399 (System locale is the same for all languages).
    Vadim Savchuk authored
    Problem:
    * English locale was set for all languages.
    * Specifying a correct locale didn't affect anything, including date/time formatting.
    
    My investigation has shown that LLStringUtil was instantiated twice: in the
    main binary and in libllcommon.so.
    Because LLStringUtil::setLocale() was called from newview and getLocale()
    was called from llcommon, they effectively used *different* instances of
    LLStringUtil::sLocale. Hence getLocale() always returned empty string.
    
    This seems to be caused by get/setLocale() methods not being dllexported.
    
    The fix instantiates get/setLocale() and sLocale in llcommon and exposes
    them to use from newview (i.e. prevents multiple instantiation).
    
    Besides, I specified correct locale names for all languages and platforms.
    
    Reviewed by Leyla: https://codereview.productengine.com/secondlife/r/104/
    
    --HG--
    branch : product-engine
Code owners
Assign users and groups as approvers for specific file changes. Learn more.