Skip to content
Snippets Groups Projects
Commit 22fcb563 authored by Nat Goodspeed's avatar Nat Goodspeed
Browse files

Log better error message in case of apr_proc_create() failure.

We were using uniform macro to report the APR function and its C++ parameter
expressions. But specifically for apr_proc_create() failure, better to report
the command we're attempting to execute.
parent 2596816f
No related branches found
No related tags found
No related merge requests found
...@@ -617,8 +617,14 @@ LLProcess::LLProcess(const LLSDOrParams& params): ...@@ -617,8 +617,14 @@ LLProcess::LLProcess(const LLSDOrParams& params):
// terminate with a null pointer // terminate with a null pointer
argv.push_back(NULL); argv.push_back(NULL);
// Launch! The NULL would be the environment block, if we were passing one. // Launch! The NULL would be the environment block, if we were passing
chkapr(apr_proc_create(&mProcess, argv[0], &argv[0], NULL, procattr, gAPRPoolp)); // one. Hand-expand chkapr() macro so we can fill in the actual command
// string instead of the variable names.
if (ll_apr_warn_status(apr_proc_create(&mProcess, argv[0], &argv[0], NULL, procattr,
gAPRPoolp)))
{
throw LLProcessError(STRINGIZE(params << " failed"));
}
// arrange to call status_callback() // arrange to call status_callback()
apr_proc_other_child_register(&mProcess, &LLProcess::status_callback, this, mProcess.in, apr_proc_other_child_register(&mProcess, &LLProcess::status_callback, this, mProcess.in,
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment