Skip to content
Snippets Groups Projects
Commit 8c1427c3 authored by Nicky Dasmijn's avatar Nicky Dasmijn
Browse files

Only set include property on ll::bugpsplat target when on Windows.

The include was preveiously declared for all platforms, but the Mac
package does not even ship this include directory. With the new way
cmake works this will lead to an error (which is good, so we don't
end with bogus include dirs).
parent 7a71cea1
No related branches found
No related tags found
No related merge requests found
...@@ -19,6 +19,7 @@ if (USE_BUGSPLAT) ...@@ -19,6 +19,7 @@ if (USE_BUGSPLAT)
target_link_libraries( ll::bugsplat INTERFACE target_link_libraries( ll::bugsplat INTERFACE
${ARCH_PREBUILT_DIRS_RELEASE}/bugsplat.lib ${ARCH_PREBUILT_DIRS_RELEASE}/bugsplat.lib
) )
target_include_directories( ll::bugsplat SYSTEM INTERFACE ${LIBS_PREBUILT_DIR}/include/bugsplat)
elseif (DARWIN) elseif (DARWIN)
find_library(BUGSPLAT_LIBRARIES BugsplatMac REQUIRED find_library(BUGSPLAT_LIBRARIES BugsplatMac REQUIRED
NO_DEFAULT_PATH PATHS "${ARCH_PREBUILT_DIRS_RELEASE}") NO_DEFAULT_PATH PATHS "${ARCH_PREBUILT_DIRS_RELEASE}")
...@@ -33,7 +34,6 @@ if (USE_BUGSPLAT) ...@@ -33,7 +34,6 @@ if (USE_BUGSPLAT)
message( FATAL_ERROR "You need to set BUGSPLAT_DB when setting USE_BUGSPLAT" ) message( FATAL_ERROR "You need to set BUGSPLAT_DB when setting USE_BUGSPLAT" )
endif() endif()
target_include_directories( ll::bugsplat SYSTEM INTERFACE ${LIBS_PREBUILT_DIR}/include/bugsplat)
set_property( TARGET ll::bugsplat APPEND PROPERTY INTERFACE_COMPILE_DEFINITIONS LL_BUGSPLAT) set_property( TARGET ll::bugsplat APPEND PROPERTY INTERFACE_COMPILE_DEFINITIONS LL_BUGSPLAT)
else() else()
set(BUGSPLAT_DB "" CACHE STRING "BugSplat crash database name") set(BUGSPLAT_DB "" CACHE STRING "BugSplat crash database name")
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment