Skip to content
Snippets Groups Projects
  1. Jul 22, 2013
  2. Jul 17, 2013
    • Nat Goodspeed's avatar
      CHOP-962: Preserve unrecognized user settings variables. · fd14c250
      Nat Goodspeed authored
      Change LLControlVariable::mPersist from bool to tri-state enum. Its 'true'
      value used to mean "persist only if changed from default;" third state now
      means "persist regardless of value." Add forcePersist() method to set that.
      Replace isSaveValueDefault() method -- used only by logic to determine whether
      to save the variable -- with shouldSave() method to encapsulate ALL that logic
      rather than only part of it. shouldSave() recognizes PERSIST_ALWAYS state.
      When loading an unrecognized control variable from a user settings file, use
      forcePersist() to ensure that we later save that variable again.
      Tweak one of the unit tests to adjust for new semantics.
      fd14c250
    • Nat Goodspeed's avatar
      CHOP-962: Make LLControlGroup::declare* return LLControlVariable* · 2b3c1bd4
      Nat Goodspeed authored
      LLControlGroup::declareControl(), declareString() etc. etc. all used to return
      BOOL -- which no one ever examines because it unconditionally returned TRUE.
      Make it return the (possibly new) LLControlVariable* instead.
      2b3c1bd4
  3. Jul 16, 2013
    • Nat Goodspeed's avatar
      CHOP-960: Validate cmd_line.xml for map-to real settings.xml vars. · cfd17448
      Nat Goodspeed authored
      A small, fixed set of cmd_line.xml switches can't reasonably be mapped to
      settings variables, mostly because they affect the settings machinery itself.
      Other than those, every new cmd_line.xml switch should map-to a settings
      variable. Validate that only the known set does not have map-to; validate that
      map-to variable actually exists.
      cfd17448
  4. Jul 11, 2013
  5. Jul 02, 2013
  6. Jul 01, 2013
    • Nat Goodspeed's avatar
      CHOP-959: Introduce and use settings vars for some cmd_line switches. · 3d9c74dc
      Nat Goodspeed authored
      The cmd_line.xml entries:
      analyzeperformance
      crashonstartup
      debugsession
      disablecrashlogger
      logmetrics
      logperformance
      noquicktime
      replaysession
      all specify map-to settings.xml variables -- none of which existed! Introduce
      such variables. Instead of detecting the presence of a particular switch in
      the command-line parser, use the value of its corresponding settings variable.
      3d9c74dc
  7. Jun 28, 2013
    • Nat Goodspeed's avatar
      CHOP-959: Streamline processing for --graphicslevel switch. · c08b60ac
      Nat Goodspeed authored
      Use map-to in cmd_line.xml to inform the command-line processor that the
      target variable for --graphicslevel is RenderQualityPerformance.
      That lets us eliminate clunky llappviewer.cpp switch from '0' to 0, etc.
      Moreover, previous switch statement only accepted 0 - 3, whereas
      LLFeatureManager::setGraphicsLevel() actually accepts 0 - 6. Introduce
      LLFeatureManager::isValidGraphicsLevel() and use that to validate.
      Replace switch statement in setGraphicsLevel() mapping int constants to string
      literals with static vector of level names, using same data for mapping as for
      validating level numbers.
      c08b60ac
  8. Jun 27, 2013
  9. Jun 25, 2013
  10. Jun 24, 2013
    • Nat Goodspeed's avatar
      CHOP-955, CHOP-957: Platform-specific switches files => settings_install.xml. · b7ac6c6b
      Nat Goodspeed authored
      Instead of generating viewer command-line switch overrides into
      the Windows shortcut,
      an arguments.txt file on Mac, or
      a gridargs.dat file on Linux,
      generate a platform-independent settings_install.xml file containing
      'sourceid' key (if 'sourceid' found in TeamCity environment variables).
      All command-line override switches previously found in the aforementioned
      files have happily become moot.
      b7ac6c6b
  11. Jun 19, 2013
  12. Jun 18, 2013
  13. Jun 14, 2013
  14. Jun 13, 2013
  15. Jun 12, 2013
Loading