Skip to content
Snippets Groups Projects
  1. Dec 14, 2018
    • Nat Goodspeed's avatar
      SL-10153: Review and rationalize fetching paths from environment. · c4096f67
      Nat Goodspeed authored
      Use LLStringUtil::getenv() or getoptenv() whenever we fetch a string that will
      be used as a pathname.
      
      Use LLFile::tmpdir() instead of getenv("TEMP").
      
      As an added extra-special bonus, finally clean up $TMP/llcontrol-test-zzzzzz
      directories that have been accumulating every time we run a local build!
      c4096f67
  2. Mar 02, 2018
  3. Dec 20, 2017
    • Nat Goodspeed's avatar
      MAINT-8087: Use env vars from VMP for AppData\Roaming and Local. · 5002bf56
      Nat Goodspeed authored
      On Windows, when logged in with a non-ASCII username, every one of the three
      documented APIs -- SHGetSpecialFolderPath(), SHGetFolderPath() and
      SHGetKnownFolderPath() -- fails to retrieve any pathname at all. We cannot
      account for the fact that the oldest of these continues to work with the
      release viewer and within a Python script (though not, curiously, from a
      Python interactive session). With a non-ASCII username, they consistently fail
      when called from an Alex Ivy viewer build: "The filename, directory name, or
      volume label syntax is incorrect."
      
      Empirically, with a non-ASCII username, the preset APPDATA and LOCALAPPDATA
      environment variables are also useless, e.g. c:\Users\??????\AppData\Roaming
      where those are, yup, actual question marks.
      
      Empirically, the VMP is able to successfully call SHGetFolderPath() to
      retrieve both AppData\Roaming and AppData\Local. Therefore, we make the VMP
      set the APPDATA and LOCALAPPDATA environment variables to the UTF-8 encoded
      correct pathnames. Instead of calling SHGetSomethingFolderPath() at all, make
      LLDir_Win32 retrieve those environment variables.
      
      Make LLFile::mkdir() treat "directory already exists" as a success case. Every
      single call fell into one of two categories: either it didn't check success at
      all, or it tested specially to exempt errno == EEXIST. Migrate that test into
      mkdir(); eliminate it from call sites.
      
      Make LLDir::append() and add() convenience functions accept variadic
      arguments. Replace add(add()...) constructs, as well as clumsy concatenations
      of directory names and getDirDelimiter(), with simple variadic add() calls.
      5002bf56
  4. Jul 21, 2016
  5. Nov 10, 2015
  6. Aug 15, 2013
  7. Mar 29, 2013
  8. Nov 12, 2012
  9. May 11, 2011
  10. Apr 26, 2011
    • Boroondas Gupte's avatar
      STORM-1182 Use string::rfind instead of string::find · c18e2f74
      Boroondas Gupte authored
      ... so the last occurance of the build prefix in the executable path
      will be matched. This should avoid cuttung too much subdirs away if
      someone checks out the source to a path already containing
      "/build-darwin-" or "/build-linux-".
      c18e2f74
  11. Apr 19, 2011
  12. Jan 13, 2011
  13. Jan 11, 2011
  14. Oct 28, 2010
  15. Oct 13, 2010
  16. Sep 21, 2010
  17. Aug 31, 2010
  18. Aug 13, 2010
  19. Feb 02, 2010
  20. Jan 18, 2010
  21. Dec 09, 2009
  22. Oct 16, 2009
  23. Sep 30, 2009
  24. Sep 10, 2009
  25. Aug 27, 2009
  26. Jul 15, 2009
  27. Jun 21, 2009
  28. May 08, 2009
  29. Jan 07, 2009
  30. Jul 22, 2008
  31. Jun 25, 2008
  32. Jun 02, 2008
  33. Oct 04, 2007
  34. Jul 20, 2007
  35. Mar 20, 2007
  36. Feb 02, 2007
  37. Jan 17, 2007
  38. Jan 03, 2007
Loading