- Mar 25, 2020
-
-
Nat Goodspeed authored
DRTVWR-476: Update tut, llca, pcre, bugsplat, zlib, expat, nvapi, glext, vlc-bin, viewer-manager, uriparser, slvoice, openjpeg, ogg_vorbis, llphysicsextensions_source, libndofdev, libhunspell, jsoncpp, jpeglib, glod, glh_linear, fmodex, dictionaries, nghttp2, libxml2, openssl, libpng, freetype, xmlrpc-epi, apr_suite, dullahan, google_breakpad, curl, kdu, havok-source, boost, colladadom, googlemock Update tut to codeticket version 539059. Update llca to codeticket version 539061. Update pcre to codeticket version 538986. Update bugsplat to codeticket version 538987. Update zlib to codeticket version 538988. Update expat to codeticket version 538990. Update nvapi to codeticket version 539058. Update glext to codeticket version 538965. Update vlc-bin to codeticket version 538966. Update viewer-manager to codeticket version 538967. Update uriparser to codeticket version 538968. Update slvoice to codeticket version 538969. Update openjpeg to codeticket version 538970. Update ogg_vorbis to codeticket version 538971. Update llphysicsextensions_source to codeticket version 538972. Update libndofdev to codeticket version 538973. Update libhunspell to codeticket version 538974. Update jsoncpp to codeticket version 538976. Update jpeglib to codeticket version 538977. Update glod to codeticket version 538980. Update glh_linear to codeticket version 538981. Update fmodex to codeticket version 538982. Update dictionaries to codeticket version 538984. Update nghttp2 to codeticket version 538985. Update libxml2 to codeticket version 539066. Update openssl to codeticket version 539067. Update libpng to codeticket version 539069. Update freetype to codeticket version 539071. Update xmlrpc-epi to codeticket version 539072. Update apr_suite to codeticket version 539073. Update dullahan to codeticket version 539088. Update google_breakpad to codeticket version 539090. Update curl to codeticket version 539091. Update kdu to codeticket version 539108. Update havok-source to codeticket version 539117. Update boost to codeticket version 539140. Update colladadom to codeticket version 539147. Update googlemock to codeticket version 539148.
-
Nat Goodspeed authored
LLWearableType::initSingleton() calls LLWearableDictionary::initParamSingleton(). LLWearableDictionary's constructor constructs specific WearableEntry instances, each of which wants to translate its name string to a user-facing label using LLWearableType::mTrans. WearableEntry's constructor was calling LLWearableType::getInstance(). Under circumstances we don't fully understand (recursive mutex misbehavior?), that could hang. Instead, pass the canonical LLWearableType instance to LLWearableDictionary's constructor, and from there into WearableEntry's constructor.
-
Nat Goodspeed authored
The tactic of pushing an empty QueuedCoproc::ptr_t to signal coprocedure close only works for LLCoprocedurePools with a single coprocedure (e.g. "Upload" and "AIS"). Only one coprocedureInvokerCoro() coroutine will pop that empty pointer and shut down properly -- the rest will continue waiting indefinitely. Rather than pushing some number of empty pointers, hopefully enough to notify all consumer coroutines, close() the queue. That will notify as many consumers as there may be. That means catching LLThreadSafeQueueInterrupt from popBack(), instead of detecting empty pointer. Also, if a queued coprocedure throws an exception, coprocedureInvokerCoro() logs it as before -- but instead of rethrowing it, the coroutine now loops back to wait for more work. Otherwise, the number of coroutines servicing the queue dwindles.
-
Nat Goodspeed authored
Also isClosed() and explicit operator bool() to detect closed state. close() causes every subsequent pushFront() to throw LLThreadSafeQueueInterrupt. Once the queue is drained, it causes popBack() to throw likewise.
-
Nat Goodspeed authored
For the main coroutine on each thread, show the 'main0' (or whatever) name instead of the empty-string name.
-
Nat Goodspeed authored
-
Nat Goodspeed authored
-
Nat Goodspeed authored
Update boost to codeticket version 533856. Update colladadom to codeticket version 533872. Update googlemock to codeticket version 533873.
-
Nat Goodspeed authored
-
Nat Goodspeed authored
-
Nat Goodspeed authored
-
Nat Goodspeed authored
-
Nat Goodspeed authored
-
Nat Goodspeed authored
-
Nat Goodspeed authored
Update boost to codeticket version 533684. Update colladadom to codeticket version 533705. Update googlemock to codeticket version 533706.
-
Nat Goodspeed authored
Now that we have the Sync class to help construct unit tests that move forward in a deterministic stepwise order, we can build suitable unit tests for LLMainThreadTask.
-
Nat Goodspeed authored
-
Nat Goodspeed authored
Actually, introduce static LLCoros::logname() and make the namespaced free function an alias for that. Because CoroData is a subclass of LLInstanceTracker with a key, every instance requires a distinct key. That conflicts with our "getName() returns empty string for default coroutine on thread" convention. Introduce a new CoroData constructor, specifically for the default coroutine on each thread, that initializes the getName() name to empty string while providing a distinct "mainN" key. Make get_CoroData() use that new constructor for its thread_local instance, passing an atomic<int> incremented each time we initialize one for a new thread. Then LLCoros::logname() returns either the getName() name or the key.
-
Nat Goodspeed authored
Using Sync with multiple threads is trickier than with coroutines. In particular, Sync::bump() was racy (get() and set() as two different operations), and threads were proceeding when they should have waited. Fortunately LLCond, on which Sync is based, already supports atomic update operations. Use that for bump(). But to nail things down even more specifically, add set(n) to complement yield_until(n). Using those methods, there should be no ambiguity about which call in one thread synchronizes with which call in the other thread.
-
Nat Goodspeed authored
-
Nat Goodspeed authored
The new LLCoros::Stop exception is intended to terminate long-lived coroutines -- not interrupt mainstream shutdown processing. Only throw it on an explicitly-launched coroutine. Make LLCoros::getName() (used by the above test) static. As with other LLCoros methods, it might be called after the LLCoros LLSingleton instance has been deleted. Requiring the caller to call instance() implies a possible need to also call wasDeleted(). Encapsulate that nuance into a static method instead.
-
Nat Goodspeed authored
-
Nat Goodspeed authored
The LLTHROW() abstraction allows us to enrich the subject exception with a boost::stacktrace -- without having to propagate the boost/stacktrace.hpp header throughout the code base. To my delight, our existing use of boost::current_exception_diagnostic_information() already reports the newly added boost::stacktrace information -- we don't have to query it specifically!
-
Nat Goodspeed authored
llexception_test.cpp is about discovering appropriate infrastructure to get good information from the LLTHROW() and LOG_UNHANDLED_EXCEPTION() mechanism. But we didn't before have a test that actually exercises them. Now we do.
-
Nat Goodspeed authored
LLStacktrace has no behavior except when you stream an instance to a std::ostream. Then it reports the current traceback at that point to the ostream. This bit of indirection is intended to avoid the boost/stacktrace.hpp header from being included everywhere.
-
Nat Goodspeed authored
-
Nat Goodspeed authored
Earlier versions of macOS manifested frustrating problems in finishing the built package. Those build steps seem to have been behaving better for a few years now. Eliminate (what we fervently hope has become) a bit of ancient cruft.
-
Nat Goodspeed authored
The new close(void) method simply acquires the logic from ~LLCoprocedureManager() (which now calls close()). It's useful, even if only in test programs, to be able to shut down all existing LLCoprocedurePools without having to name them individually -- and without having to destroy the LLCoprocedureManager singleton instance. Deleting an LLSingleton should be done only once per process, whereas test programs want to reset the LLCoprocedureManager after each test.
-
Nat Goodspeed authored
Sometimes it's useful to be able to temporarily override an existing LOGFAIL setting in the current environment. It's far more convenient to prepend LOGFAIL='' to a command than to 'unset LOGFAIL' as a whole separate command -- and then remember to restore its previous value.
-
Nat Goodspeed authored
We've observed buffered_channel::try_push() hanging, which seems very odd. Try our own LLThreadSafeQueue instead.
-
Nat Goodspeed authored
-
Nat Goodspeed authored
Reinstate LLCoprocedureManager::countPending() and count() methods. These were removed because boost::fibers::buffered_channel has no size() method, but since all users run within a single thread, it works to increment and decrement a simple counter. Add count information and max queue size to log messages.
-
Nat Goodspeed authored
-
Nat Goodspeed authored
-
Nat Goodspeed authored
-
Nat Goodspeed authored
But leave LLTempRedirect available in the code base.
-
Nat Goodspeed authored
LLSD::emptyMap() is a factory for an empty map instance, NOT a predicate on any particular instance. In fact checking configuration.isUndefined() and testing whether the map is empty are both subsumed by (! configuration).
-
Nat Goodspeed authored
-
Nat Goodspeed authored
That way, if there's a problem, a developer can rerun the same command.
-
Nat Goodspeed authored
Specify all of msvcp$VER.dll, msvcr$VER.dll and vcruntime$VER.dll -- but check each of them individually, because any given VS release has only a subset of those. Add messaging to clarify what we're doing. Introduce to_staging_dirs CMake macro to cut down on redundant boilerplate: the idiom in which we use copy_if_different twice, once to the Release staging directory and once to the RelWithDebInfo staging directory, each time appending the target pathnames to third_party_targets. Replace that idiom with calls to to_staging_dirs.
-