Skip to content
Snippets Groups Projects
Select Git revision
  • main default protected
  • next protected
  • UI-EvenMoreTweaks
  • merge/materials_featurette protected
  • merge/webrtc protected
  • darl/linux-sh-installer
  • xenhat/maint/bolt
  • xenhat/features/cinematic-mode-new
  • screensquare
  • ssestuff
  • spdlog
  • 7.1.7.2486-beta
  • 7.1.4.2442-beta
  • 7.1.4.2413-beta
  • 7.1.3.2338-beta
  • 7.1.3.2332-beta
  • 7.1.2.2304-beta
  • 7.1.1.2251-beta
  • 7.0.1.2244-beta
  • 7.0.1.2240-beta
  • 7.0.1.2230-beta
  • 7.0.1.2206-beta
22 results
Search by author
  • Any Author
  • Beq Beq beq
  • Botnet4U Botnet4U cinderblocks
  • Doug Falta Doug Falta OrangeStripyDog
  • Félix Félix FelixWolf
  • Kadah Coba Kadah Coba Kadah
  • Kayla Kayla nopjmp
  • Liru Faers Liru Faers Liru
  • Nia Frostypaws Nia Frostypaws Ni-dra
  • NiranV NiranV NiranV.Dean
  • Rye Mutt Rye Mutt rye
  • Shadoskill Heckroth Shadoskill Heckroth shadoskill
  • Shyotl Shyotl Shyotl
  • Xenhat Hex Xenhat Hex XenHat
  • Zanibar Darkstone Zanibar Darkstone Zanibar
14 authors
  1. Sep 28, 2020
  3. Jul 27, 2020
  5. Mar 13, 2019
  7. Nov 22, 2018
  9. Sep 19, 2018
  11. Aug 01, 2018
  13. Jun 08, 2018
  15. Sep 19, 2017
  17. Apr 26, 2017
  19. Mar 20, 2017
  21. Feb 14, 2017
  23. Sep 15, 2016
    • Nat Goodspeed's avatar
      MAINT-5232: Normalize LLSingleton subclasses. · d2c3c2f9
      Nat Goodspeed authored 
      A shocking number of LLSingleton subclasses had public constructors -- and in
several instances, were being explicitly instantiated independently of the
LLSingleton machinery. This breaks the new LLSingleton dependency-tracking
machinery. It seems only fair that if you say you want an LLSingleton, there
should only be ONE INSTANCE!

Introduce LLSINGLETON() and LLSINGLETON_EMPTY_CTOR() macros. These handle the
friend class LLSingleton<whatevah>;
and explicitly declare a private nullary constructor.

To try to enforce the LLSINGLETON() convention, introduce a new pure virtual
LLSingleton method you_must_use_LLSINGLETON_macro() which is, as you might
suspect, defined by the macro. If you declare an LLSingleton subclass without
using LLSINGLETON() or LLSINGLETON_EMPTY_CTOR() in the class body, you can't
instantiate the subclass for lack of a you_must_use_LLSINGLETON_macro()
implementation -- which will hopefully remind the coder.

Trawl through ALL LLSingleton subclass definitions, sprinkling in
LLSINGLETON() or LLSINGLETON_EMPTY_CTOR() as appropriate. Remove all explicit
constructor declarations, public or private, along with relevant 'friend class
LLSingleton<myself>' declarations. Where destructors are declared, move them
into private section as well. Where the constructor was inline but nontrivial,
move out of class body.

Fix several LLSingleton abuses revealed by making ctors/dtors private:

LLGlobalEconomy was both an LLSingleton and the base class for
LLRegionEconomy, a non-LLSingleton. (Therefore every LLRegionEconomy instance
contained another instance of the LLGlobalEconomy "singleton.") Extract
LLBaseEconomy; LLGlobalEconomy is now a trivial subclass of that.
LLRegionEconomy, as you might suspect, now derives from LLBaseEconomy.

LLToolGrab, an LLSingleton, was also explicitly instantiated by
LLToolCompGun's constructor. Extract LLToolGrabBase, explicitly instantiated,
with trivial subclass LLToolGrab, the LLSingleton instance.

(WARNING: LLToolGrabBase methods have an unnerving tendency to go after
LLToolGrab::getInstance(). I DO NOT KNOW what should be the relationship
between the instance in LLToolCompGun and the LLToolGrab singleton instance.)

LLGridManager declared a variant constructor accepting (const std::string&),
with the comment:
// initialize with an explicity grid file for testing.
As there is no evidence of this being called from anywhere, delete it.

LLChicletBar's constructor accepted an optional (const LLSD&). As the LLSD
parameter wasn't used, and as there is no evidence of it being passed from
anywhere, delete the parameter.

LLViewerWindow::shutdownViews() was checking LLNavigationBar::
instanceExists(), then deleting its getInstance() pointer -- leaving a
dangling LLSingleton instance pointer, a land mine if any subsequent code
should attempt to reference it. Use deleteSingleton() instead.

~LLAppViewer() was calling LLViewerEventRecorder::instance() and then
explicitly calling ~LLViewerEventRecorder() on that instance -- leaving the
LLSingleton instance pointer pointing to an allocated-but-destroyed instance.
Use deleteSingleton() instead.
      d2c3c2f9
  25. Nov 10, 2015
  27. Mar 29, 2013
  29. Jun 07, 2012
  31. Oct 03, 2011
  33. Oct 13, 2010
  35. Sep 21, 2010
  37. Aug 13, 2010
  39. Jul 13, 2010
  41. Jun 10, 2010
  43. Apr 27, 2010
  45. Apr 01, 2010
  47. Mar 31, 2010
    • Loren Shih's avatar
      EXT-5581 : Centralize is_asset_fetch/knowlable into asset dictionary · d4fef262
      Loren Shih authored 
      Took out some ugly case statements and stuck those functions into the asset dictionary instead.  This makes the code a lot more centralized/extensible since if we ever add assets, it'll be clear that their fetch/knowable fields need to be added (versus that logic being in some obscure case statement).
      d4fef262
  49. Nov 04, 2009
  51. Nov 02, 2009
  53. Oct 16, 2009
  55. Sep 10, 2009
  57. Aug 31, 2009
  59. Aug 18, 2009
  61. Aug 12, 2009
  63. Jul 23, 2009
  65. Jun 24, 2009
  67. Jun 21, 2009
  69. May 08, 2009
  71. Jan 07, 2009
  73. Jul 31, 2008
  75. Jun 25, 2008