Skip to content
Snippets Groups Projects
  1. Aug 24, 2018
    • Nat Goodspeed's avatar
      DRTVWR-447: Introduce explicit CMake BUGSPLAT_DB variable. · c2178bb6
      Nat Goodspeed authored
      Define the CMake cache variable, with empty string as its default.
      
      Make build.sh pass the BUGSPLAT_DB environment variable as a CMake
      command-line variable assignment.
      
      Change CMake 'if (DEFINED ENV{BUGSPLAT_DB})' to plain 'if (BUGSPLAT_DB)'.
      
      Make CMake pass new --bugsplat switch to every one of SIX different
      invocations of viewer_manifest.py.
      
      Give llmanifest.main() function an argument to allow supplementing the base
      set of command-line switches with additional application-specific switches.
      
      In viewer_manifest.py, define new --bugsplat command-line switch and pass to
      llmanifest.main(). Instead of consulting os.environ['BUGSPLAT_DB'], consult
      self.args['bugsplat'].
      c2178bb6
  2. Jun 14, 2018
  3. May 17, 2018
    • Nat Goodspeed's avatar
      SL-821: Move Windows BugSplat engagement from llcommon to newview. · c5f618d0
      Nat Goodspeed authored
      Use WSTRINGIZE(), LL_TO_WSTRING(), wstringize() to produce required wide
      strings. Use a lambda for callback that sends log file; use LLDir, if set, to
      find the log file.
      
      Introduce BUGSPLAT CMake variable to allow suppressing BugSplat.
      Make BUGSPLAT CMake variable set LL_BUGSPLAT for C++ compilations.
      
      Set viewer version macros on llappviewerwin32.cpp, llappviewerlinux.cpp and
      llappdelegate-objc.mm -- because BugSplat needs the viewer version data, and
      because the macOS BugSplat hook is engaged in an Objective-C++ function we
      override in the app delegate.
      c5f618d0
  4. May 11, 2018
  5. Dec 14, 2017
  6. Oct 24, 2017
  7. Oct 18, 2017
  8. Jul 28, 2017
  9. May 10, 2017
    • Nat Goodspeed's avatar
      Add LLEventThrottle tests; actually *all* lleventfilter.cpp tests. · 9c66072c
      Nat Goodspeed authored
      For some reason there wasn't an entry in indra/llcommon/CMakeLists.txt to run
      the tests in indra/llcommon/tests/lleventfilter_test.cpp. It seems likely that
      at some point it existed, since all previous tests built and ran successfully.
      In any case, (re-)add lleventfilter_test.cpp to the set of llcommon tests.
      Also alphabetize them to make it easier to find a particular test invocation.
      
      Also add new tests for LLEventThrottle.
      
      To support this, refactor the concrete LLEventThrottle class into
      LLEventThrottleBase containing all the tricky logic, with pure virtual
      methods for access to LLTimer and LLEventTimeout, and an LLEventThrottle
      subclass containing the LLTimer and LLEventTimeout instances and corresponding
      implementations of the new pure virtual methods.
      
      That permits us to introduce TestEventThrottle, an alternate subclass with
      dummy implementations of the methods related to LLTimer and LLEventTimeout. In
      particular, we can explicitly advance simulated realtime to simulate
      particular LLTimer and LLEventTimeout behaviors.
      
      Finally, introduce Concat, a test LLEventPump listener class whose function is
      to concatenate received string event data into a composite string so we can
      readily test for particular sequences of events.
      9c66072c
  10. Dec 01, 2016
    • Nat Goodspeed's avatar
      DRTVWR-418: Until we figure out how to say FIXED:NO to linker, don't. · 8a461c00
      Nat Goodspeed authored
      The present CMake logic wants to pass FIXED:NO to the linker for 64-bit
      builds, which on the face of it seems like a Good Thing: it permits code to be
      relocated in memory, preventing collisions if two libraries happen to want to
      load into overlapping address ranges.
      
      However the way it's being specified is wrong and harmful. Passing /FIXED:NO
      to the compiler command line engages /FI (Forced Include!) of a nonexistent
      file XED:NO -- producing lots of baffling fatal compile errors.
      
      Thanks Callum for diagnosing this!
      8a461c00
  11. Nov 15, 2016
    • Nat Goodspeed's avatar
      DRTVWR-418: Fold windows64 into windows platform with new autobuild. · 6c7a9728
      Nat Goodspeed authored
      autobuild 1.1 now supports expanding $variables within a config file --
      support that was explicitly added to address this very problem. So now the
      windows platform in autobuild.xml uses $AUTOBUILD_ADDRSIZE,
      $AUTOBUILD_WIN_VSPLATFORM and $AUTOBUILD_WIN_CMAKE_GEN, which should handle
      most of the deltas between the windows platform and windows64.
      
      This permits removing the windows64 platform definition from autobuild.xml.
      
      The one remaining delta between the windows64 and windows platform definitions
      was -DLL_64BIT_BUILD=TRUE. But we can handle that instead by checking
      ADDRESS_SIZE. Change all existing references to WORD_SIZE to ADDRESS_SIZE
      instead, and set ADDRESS_SIZE to $AUTOBUILD_ADDRSIZE. Change the one existing
      LL_64BIT_BUILD reference to test (ADDRESS_SIZE EQUAL 64) instead.
      6c7a9728
  12. Oct 12, 2016
  13. Sep 03, 2016
  14. Aug 30, 2016
    • Nat Goodspeed's avatar
      MAINT-5232: Move "llerror.h" out of llcleanup.h, llinitdestroyclass.h · dcdccb3e
      Nat Goodspeed authored
      Introduce corresponding llcleanup.cpp, llinitdestroyclass.cpp modules to
      contain code that performs logging calls.
      
      Track class::method names for LLInitClass<T> and LLDestroyClass<T> subclasses,
      and log them when called. The order in which these calls occur could be
      relevant to bugs, and could surface the need to convert to LLSingleton
      dependencies.
      dcdccb3e
  15. Aug 17, 2016
    • Nat Goodspeed's avatar
      MAINT-5011: Add llexception_test.cpp with tests (and conclusions). · 1ed76c38
      Nat Goodspeed authored
      llexception_test.cpp is an unusual test source in that it need not be verified
      on every build, so its invocation in indra/llcommon/CMakeLists.txt is
      commented out with that remark. Its purpose is to help a developer decide what
      base class(es) to use for LLException, how to throw and how to catch.
      
      Our current conclusions are written up as comments in llexception_test.cpp.
      
      Added CRASH_ON_UNHANDLED_EXCEPTION() and LOG_UNHANDLED_EXCEPTION() macros to
      llexception.h -- macros to log __FILE__, __LINE__ and __PRETTY_FUNCTION__ of
      the catch site. These invoke functions in llexception.cpp so we don't need to
      #include llerror.h for every possible catch site.
      1ed76c38
  16. Jul 19, 2016
    • Nat Goodspeed's avatar
      MAINT-5011: Introduce LLException base class for viewer exceptions. · 9c49a6c9
      Nat Goodspeed authored
      This also introduces LLContinueError for exceptions which should interrupt
      some part of viewer processing (e.g. the current coroutine) but should attempt
      to let the viewer session proceed.
      
      Derive all existing viewer exception classes from LLException rather than from
      std::runtime_error or std::logic_error.
      
      Use BOOST_THROW_EXCEPTION() rather than plain 'throw' to enrich the thrown
      exception with source file, line number and containing function.
      9c49a6c9
  17. Apr 21, 2016
  18. Jan 26, 2016
  19. Dec 18, 2015
  20. Nov 20, 2015
  21. Nov 10, 2015
  22. Oct 31, 2015
  23. Oct 17, 2015
  24. Aug 25, 2015
  25. Aug 19, 2015
  26. Jun 17, 2015
  27. May 27, 2015
    • Nat Goodspeed's avatar
      MAINT-5232: Extract LLInitClass, LLDestroyClass from llui/llui.h · 9f962c03
      Nat Goodspeed authored
      to a new llcommon/llinitdestroyclass.h.
      This mechanism is so general -- but has so many related moving parts -- that
      (a) it deserves to be in a header file all its own, instead of conflated with
      llui.h, and (b) it should be in llcommon where anyone can use it. It has no
      dependencies whatsoever on llui or anything viewer-specific.
      In this very changeset we changed one #include "llui.h" whose comment admits
      that it was only dragged in for LLDestroyClass.
      9f962c03
  28. May 22, 2015
    • Nat Goodspeed's avatar
      MAINT-5232: Add LLPounceable template for delayed registrations. · df3da846
      Nat Goodspeed authored
      LLMuteList, an LLSingleton, overrides its getInstance() method to intercept
      control every time a consumer wants LLMuteList. This "polling" is to notice
      when gMessageSystem becomes non-NULL, and register a couple callbacks on it.
      Unfortunately there are a couple ways to request the LLMuteList instance
      without specifically calling the subclass getInstance(), which would bypass
      that logic. Moreover, the polling feels a bit dubious to start with.
      LLPounceable<T*> presents an idiom in which you can callWhenReady(callable) on
      the LLPounceable instance. If the T* is already non-NULL, it calls the
      callable immediately; otherwise it enqueues it for when the T* is set
      non-NULL. (This lets you "pounce" on the T* as soon as it becomes available,
      hence the name.) So if gMessageSystem were an LLPounceable<LLMessageSystem*>,
      LLMuteList's constructor could simply call gMessageSystem.callWhenReady() and
      relax: the callbacks would be registered either on LLMuteList construction or
      LLMessageSystem initialization, whichever comes later.
      LLPounceable comes with its very own set of unit tests. However, as of this
      commit it is not yet used in actual viewer code.
      df3da846
  29. May 20, 2015
  30. Oct 22, 2014
  31. Oct 07, 2014
  32. Apr 22, 2014
  33. Apr 08, 2014
  34. Apr 04, 2014
  35. Oct 03, 2013
  36. Aug 27, 2013
  37. Aug 22, 2013
  38. Jul 30, 2013
  39. Jun 22, 2013
Loading