Skip to content
Snippets Groups Projects
  1. Sep 15, 2016
    • Nat Goodspeed's avatar
      MAINT-5232: Normalize LLSingleton subclasses. · d2c3c2f9
      Nat Goodspeed authored
      A shocking number of LLSingleton subclasses had public constructors -- and in
      several instances, were being explicitly instantiated independently of the
      LLSingleton machinery. This breaks the new LLSingleton dependency-tracking
      machinery. It seems only fair that if you say you want an LLSingleton, there
      should only be ONE INSTANCE!
      
      Introduce LLSINGLETON() and LLSINGLETON_EMPTY_CTOR() macros. These handle the
      friend class LLSingleton<whatevah>;
      and explicitly declare a private nullary constructor.
      
      To try to enforce the LLSINGLETON() convention, introduce a new pure virtual
      LLSingleton method you_must_use_LLSINGLETON_macro() which is, as you might
      suspect, defined by the macro. If you declare an LLSingleton subclass without
      using LLSINGLETON() or LLSINGLETON_EMPTY_CTOR() in the class body, you can't
      instantiate the subclass for lack of a you_must_use_LLSINGLETON_macro()
      implementation -- which will hopefully remind the coder.
      
      Trawl through ALL LLSingleton subclass definitions, sprinkling in
      LLSINGLETON() or LLSINGLETON_EMPTY_CTOR() as appropriate. Remove all explicit
      constructor declarations, public or private, along with relevant 'friend class
      LLSingleton<myself>' declarations. Where destructors are declared, move them
      into private section as well. Where the constructor was inline but nontrivial,
      move out of class body.
      
      Fix several LLSingleton abuses revealed by making ctors/dtors private:
      
      LLGlobalEconomy was both an LLSingleton and the base class for
      LLRegionEconomy, a non-LLSingleton. (Therefore every LLRegionEconomy instance
      contained another instance of the LLGlobalEconomy "singleton.") Extract
      LLBaseEconomy; LLGlobalEconomy is now a trivial subclass of that.
      LLRegionEconomy, as you might suspect, now derives from LLBaseEconomy.
      
      LLToolGrab, an LLSingleton, was also explicitly instantiated by
      LLToolCompGun's constructor. Extract LLToolGrabBase, explicitly instantiated,
      with trivial subclass LLToolGrab, the LLSingleton instance.
      
      (WARNING: LLToolGrabBase methods have an unnerving tendency to go after
      LLToolGrab::getInstance(). I DO NOT KNOW what should be the relationship
      between the instance in LLToolCompGun and the LLToolGrab singleton instance.)
      
      LLGridManager declared a variant constructor accepting (const std::string&),
      with the comment:
      // initialize with an explicity grid file for testing.
      As there is no evidence of this being called from anywhere, delete it.
      
      LLChicletBar's constructor accepted an optional (const LLSD&). As the LLSD
      parameter wasn't used, and as there is no evidence of it being passed from
      anywhere, delete the parameter.
      
      LLViewerWindow::shutdownViews() was checking LLNavigationBar::
      instanceExists(), then deleting its getInstance() pointer -- leaving a
      dangling LLSingleton instance pointer, a land mine if any subsequent code
      should attempt to reference it. Use deleteSingleton() instead.
      
      ~LLAppViewer() was calling LLViewerEventRecorder::instance() and then
      explicitly calling ~LLViewerEventRecorder() on that instance -- leaving the
      LLSingleton instance pointer pointing to an allocated-but-destroyed instance.
      Use deleteSingleton() instead.
      d2c3c2f9
  2. Sep 06, 2016
    • Nat Goodspeed's avatar
      MAINT-5232: Prevent runaway LLSingletonBase::MasterList growth. · 1cadeb40
      Nat Goodspeed authored
      Until we reimplement LLCoros on Boost.Fiber, we must hand-implement
      coroutine-local data. That presently takes the form of a map keyed on
      llcoro::id, whose values are the stacks of currently-initializing LLSingleton
      instances.
      
      But since the viewer launches an open-ended number of coroutines, we could end
      up with an open-ended number of map entries unless we intentionally prune the
      map. So every time we pop the stack to empty, remove that map entry.
      
      This could result in thrashing, a given coroutine's 'initializing' stack being
      created and deleted for almost every LLSingleton instantiated by that
      coroutine -- but the number of different LLSingletons is necessarily static,
      and the lifespan of each is the entire rest of the process. Even a couple
      dozen LLSingletons won't thrash that badly.
      1cadeb40
    • Nat Goodspeed's avatar
      MAINT-5232: Make LLSingleton's 'initializing' stack coro-specific. · 90f42498
      Nat Goodspeed authored
      The stack we maintain of which LLSingletons are currently initializing only
      makes sense when associated with a particular C++ call stack. But each
      coroutine introduces another C++ call stack!
      
      Move the initializing stack from function-static storage to
      LLSingletonBase::MasterList. Make it a map keyed by llcoro::id. Each coro then
      has a stack of its own.
      
      This introduces more dependencies on the MasterList singleton, requiring
      additional LLSingleton_manage_master workarounds.
      90f42498
  3. Sep 03, 2016
    • Nat Goodspeed's avatar
      MAINT-5232: Add DEBUG logging to LLSingleton dependency tracking. · c71e6222
      Nat Goodspeed authored
      Specifically, add DEBUG logging to the code that maintains the stack of
      LLSingletons currently being initialized. This involves passing
      LLSingletonBase's constructor the name of LLSingleton's template parameter
      subclass, since during that constructor typeid(*this).name() will only produce
      "LLSingletonBase".
      
      Also add logdebugs() and oktolog() helper functions.
      c71e6222
  4. Sep 01, 2016
  5. Aug 31, 2016
  6. Aug 30, 2016
  7. Nov 10, 2015
  8. Jun 26, 2015
  9. Jun 25, 2015
    • Nat Goodspeed's avatar
      MAINT-5232: Try to avoid circularity between LLError and LLSingleton. · 0ea1b2a1
      Nat Goodspeed authored
      Part of LLError's logging infrastructure is implemented with an LLSingleton.
      Therefore, attempts to log from within LLSingleton machinery could potentially
      go south if LLError's LLSingleton is not yet initialized.
      Introduce LLError::is_available() in llerrorcontrol.h and llerror.cpp.
      Make LLSingletonBase::logwarns() and logerrs() consult LLError::is_available()
      before attempting to use LL_WARNS or LL_ERRS, respectively.
      Moreover, make all LLSingleton internal logging use logwarns() and logerrs()
      instead of directly engaging LL_ERRS or LL_WARNS.
      0ea1b2a1
  10. Jun 24, 2015
    • Nat Goodspeed's avatar
      MAINT-5232: Introduce inter-LLSingleton dependency tracking. · d792baf9
      Nat Goodspeed authored
      Introduce LLSingleton::cleanupSingleton() canonical method as the place to put
      any subclass cleanup logic that might take nontrivial realtime or throw an
      exception. Neither is appropriate in a destructor.
      Track all extant LLSingleton subclass instances on a master list, which
      permits adding LLSingletonBase::cleanupAll() and deleteAll() methods.
      Also notice when any LLSingleton subclass constructor (or initSingleton()
      method) calls instance() or getInstance() for another LLSingleton, and capture
      that other LLSingleton instance as a dependency of the first. This permits
      cleanupAll() and deleteAll() to perform a dependency sort on the master list,
      thus cleaning up (or deleting) leaf LLSingletons AFTER the LLSingletons that
      depend on them.
      Make C++ runtime's final static destructor call LLSingletonBase::deleteAll()
      instead of deleting individual LLSingleton instances in arbitrary order.
      Eliminate "llerror.h" from llsingleton.h, a longstanding TODO.
      d792baf9
  11. Apr 24, 2013
  12. Mar 29, 2013
  13. Oct 13, 2010
  14. Sep 21, 2010
  15. Aug 13, 2010
  16. Aug 06, 2009
  17. Aug 05, 2009
  18. Jun 30, 2009
  19. Jun 21, 2009
  20. May 08, 2009
  21. Feb 25, 2009
    • Robert Knop's avatar
      svn merge -r108815:112761 svn+ssh://svn.lindenlab.com/svn/linden/branches/server/server-1.26 · c88b470a
      Robert Knop authored
      The biggest things in this are Scalable Space Servers and Maint-Server-6
      
      QAR-1209 : SSS
      QAR-1295 : maint-server-6
      
      Conflicts resolved by prospero:
      
      C    scripts/farm_distribute
      
      C    scripts/automated_build_scripts/build-linux.sh : resolved by
                           prospero, mostly kept the merge-right version in
                           the conflict, but there was one block of repeated
                           code from earlier that I removed.
      
      C    scripts/automated_build_scripts/build-mac.sh : kept merge-right
      
      C    indra/llcommon/llversionserver.h : svn revert
      
      C    indra/newsim/llsimparcel.h : kept *both*... working had "setArea",
                          merge-right had exportStream and importStream
      
      C    indra/newsim/llsimparcel.cpp : see llsimparcel.h
      
      C    indra/newsim/lltask.h : working had LLTask derived also from
                         LLScriptResourceConsumer, merge-right had LLTask
                         dervied also from LLAgentPosition.  To resolve
                         conflict, derive from both.
      
      C    indra/newsim/lllslmanager.h : kept merge-right (had an added comment)
      
      C    indra/llmessage/llhttpnode.h : kept working (added the definition
                         of method LLHTTPNode::extendedResult)
      
      C    indra/lscript/lscript_execute_mono/llscriptexecutemono.cpp
      C    indra/lscript/lscript_execute_mono/llscriptexecutemono.h
                        : These two were resolved by si, in consultation with daveh
      
      
      I also had to add the following stubs to
      indra/newsim/tests/llgodkickutils_test.cpp in order to get it to
      compile:
      
        // LLScriptResourceConsumer interface methods in LLTask
        LLScriptResource::LLScriptResource() { }
        LLScriptResourcePool::LLScriptResourcePool() { }
        LLScriptResourcePool LLScriptResourcePool::null;
      
        LLScriptResourceConsumer::LLScriptResourceConsumer() { }
        LLScriptResourcePool& LLScriptResourceConsumer::getScriptResourcePool() { return LLScriptResourcePool::null; }
        const LLScriptResourcePool& LLScriptResourceConsumer::getScriptResourcePool() const { return LLScriptResourcePool::null; }
        bool LLScriptResourceConsumer::switchScriptResourcePools(LLScriptResourcePool& new_pool) { return false; }
        bool LLScriptResourceConsumer::canUseScriptResourcePool(const LLScriptResourcePool& resource_pool) { return false; }
        bool LLScriptResourceConsumer::isInPool(const LLScriptResourcePool& resource_pool) { return false; }
        void LLScriptResourceConsumer::setScriptResourcePool(LLScriptResourcePool& pool) { }
      
        S32 LLTask::getUsedPublicURLs() const { return 0; }
        void LLTask::setScriptResourcePool(LLScriptResourcePool& pool) { }
      c88b470a
  22. Jan 07, 2009
  23. Oct 04, 2007
  24. Jan 02, 2007
Loading